From 037b0bcb36617f6ee68c00ce1b55c4d5067e74a6 Mon Sep 17 00:00:00 2001
From: Tom Robinson <tlrobinson@gmail.com>
Date: Mon, 29 Oct 2018 14:35:12 -0700
Subject: [PATCH] Fix column title setting for non-number columns. Resolves
#8756
---
.../visualizations/lib/settings/column.js | 22 +++++++++----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/frontend/src/metabase/visualizations/lib/settings/column.js b/frontend/src/metabase/visualizations/lib/settings/column.js
index 6e9ece18390..b264604312f 100644
--- a/frontend/src/metabase/visualizations/lib/settings/column.js
+++ b/frontend/src/metabase/visualizations/lib/settings/column.js
@@ -414,17 +414,6 @@ export const NUMBER_COLUMN_SETTINGS = {
"currency_header_only",
],
},
- _column_title_full: {
- getValue: (column: Column, settings: ColumnSettings) => {
- let columnTitle = settings["column_title"] || formatColumn(column);
- const headerUnit = settings["_header_unit"];
- if (headerUnit) {
- columnTitle += ` (${headerUnit})`;
- }
- return columnTitle;
- },
- readDependencies: ["column_title", "_header_unit"],
- },
};
const COMMON_COLUMN_SETTINGS = {
@@ -438,6 +427,17 @@ const COMMON_COLUMN_SETTINGS = {
column: {
getValue: column => column,
},
+ _column_title_full: {
+ getValue: (column: Column, settings: ColumnSettings) => {
+ let columnTitle = settings["column_title"] || formatColumn(column);
+ const headerUnit = settings["_header_unit"];
+ if (headerUnit) {
+ columnTitle += ` (${headerUnit})`;
+ }
+ return columnTitle;
+ },
+ readDependencies: ["column_title", "_header_unit"],
+ },
};
export function getSettingDefintionsForColumn(series: Series, column: Column) {
--
GitLab