diff --git a/frontend/src/metabase/admin/settings/app/components/SettingsEditor/SettingsEditor.jsx b/frontend/src/metabase/admin/settings/app/components/SettingsEditor/SettingsEditor.jsx index 10c062dbb0f039bd7d8a420a0883a071c6391194..b457c305b30d7481cb9bdfcc3dbe03696c5889b6 100644 --- a/frontend/src/metabase/admin/settings/app/components/SettingsEditor/SettingsEditor.jsx +++ b/frontend/src/metabase/admin/settings/app/components/SettingsEditor/SettingsEditor.jsx @@ -9,7 +9,6 @@ import { t } from "ttag"; import _ from "underscore"; import ErrorBoundary from "metabase/ErrorBoundary"; -import { prepareAnalyticsValue } from "metabase/admin/settings/utils"; import { UpsellSSO } from "metabase/admin/upsells"; import { AdminLayout } from "metabase/components/AdminLayout"; import { NotFound } from "metabase/components/ErrorPages"; @@ -17,7 +16,6 @@ import SaveStatus from "metabase/components/SaveStatus"; import AdminS from "metabase/css/admin.module.css"; import CS from "metabase/css/core/index.css"; import title from "metabase/hoc/Title"; -import * as MetabaseAnalytics from "metabase/lib/analytics"; import MetabaseSettings from "metabase/lib/settings"; import { Box } from "metabase/ui"; @@ -141,16 +139,6 @@ class SettingsEditor extends Component { } else { this.saveStatusRef.current.setSaved(); } - - const value = prepareAnalyticsValue(setting); - - MetabaseAnalytics.trackStructEvent( - "General Settings", - setting.display_name || setting.key, - value, - // pass the actual value if it's a number - typeof value === "number" && value, - ); } catch (error) { console.error(error); const message = @@ -159,11 +147,6 @@ class SettingsEditor extends Component { if (options?.onError) { options.onError(error, message); } - MetabaseAnalytics.trackStructEvent( - "General Settings", - setting.display_name, - "error", - ); } }; diff --git a/frontend/src/metabase/admin/settings/utils.js b/frontend/src/metabase/admin/settings/utils.js index 6ebef8285f8f03731334d4408011ae39d91af890..3e1e79992a7b7f0f1f195e10f9f5460324571782 100644 --- a/frontend/src/metabase/admin/settings/utils.js +++ b/frontend/src/metabase/admin/settings/utils.js @@ -2,13 +2,6 @@ import { t } from "ttag"; import MetabaseSettings from "metabase/lib/settings"; -// in order to prevent collection of identifying information only fields -// that are explicitly marked as collectable or booleans should show the true value -export const prepareAnalyticsValue = setting => - setting.allowValueCollection || setting.type === "boolean" - ? setting.value - : "success"; - export const settingToFormField = setting => ({ name: setting.key, label: setting.display_name, diff --git a/frontend/src/metabase/admin/settings/utils.unit.spec.js b/frontend/src/metabase/admin/settings/utils.unit.spec.js deleted file mode 100644 index a5ca55b200e7150c15524d5bff6085674eb96446..0000000000000000000000000000000000000000 --- a/frontend/src/metabase/admin/settings/utils.unit.spec.js +++ /dev/null @@ -1,21 +0,0 @@ -import { prepareAnalyticsValue } from "metabase/admin/settings/utils"; - -describe("prepareAnalyticsValue", () => { - const defaultSetting = { value: 120, type: "number" }; - - it("should return a non identifying value by default", () => { - expect(prepareAnalyticsValue(defaultSetting)).toBe("success"); - }); - - it("should return the value of a setting marked collectable", () => { - expect( - prepareAnalyticsValue({ ...defaultSetting, allowValueCollection: true }), - ).toBe(defaultSetting.value); - }); - - it('should return the value of a setting with a type of "boolean" collectable', () => { - expect(prepareAnalyticsValue({ ...defaultSetting, type: "boolean" })).toBe( - defaultSetting.value, - ); - }); -});