From 08740c1b254b26651bd42194c98c4e90b9421b21 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cam=20Sa=C3=BCl?= <cammsaul@gmail.com>
Date: Wed, 7 Jun 2017 17:06:42 -0700
Subject: [PATCH] Add some tests :wrench:

---
 test/metabase/driver_test.clj | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/test/metabase/driver_test.clj b/test/metabase/driver_test.clj
index a2651796dbf..c63925e7281 100644
--- a/test/metabase/driver_test.clj
+++ b/test/metabase/driver_test.clj
@@ -16,3 +16,23 @@
 
 (expect true  (driver/driver-supports? (TestDriver.) :a))
 (expect false (driver/driver-supports? (TestDriver.) :b))
+
+;; values->base-type
+(expect
+  :type/Text
+  (driver/values->base-type ["A" "B" "C"]))
+
+;; should ignore nils
+(expect
+  :type/Text
+  (driver/values->base-type [nil nil "C"]))
+
+;; should pick base-type of most common class
+(expect
+  :type/Text
+  (driver/values->base-type ["A" 100 "C"]))
+
+;; should fall back to :type/* if no better type is found
+(expect
+  :type/*
+  (driver/values->base-type [(Object.)]))
-- 
GitLab