From 089e02dd6d6dfdf9040dc3540d7fd31ea624c1e7 Mon Sep 17 00:00:00 2001
From: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Date: Wed, 4 Aug 2021 14:06:43 -0700
Subject: [PATCH] Change default for currency style to code if symbol not
supported (#17301)
---
.../src/metabase/visualizations/lib/settings/column.js | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/frontend/src/metabase/visualizations/lib/settings/column.js b/frontend/src/metabase/visualizations/lib/settings/column.js
index f37031eb452..3bcfedbcf80 100644
--- a/frontend/src/metabase/visualizations/lib/settings/column.js
+++ b/frontend/src/metabase/visualizations/lib/settings/column.js
@@ -354,7 +354,12 @@ export const NUMBER_COLUMN_SETTINGS = {
],
};
},
- default: "symbol",
+ getDefault: (column: Column, settings: ColumnSettings) => {
+ const c = settings["currency"] || "USD";
+ return getCurrency(c, "symbol") !== getCurrency(c, "code")
+ ? "symbol"
+ : "code";
+ },
getHidden: (column: Column, settings: ColumnSettings) =>
settings["number_style"] !== "currency",
readDependencies: ["number_style"],
--
GitLab