From 089fa547636589af03a0a28db95b6c979f1f0bb8 Mon Sep 17 00:00:00 2001
From: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Date: Wed, 5 Jan 2022 15:35:33 +0100
Subject: [PATCH] Unskip repro for #16273 (#19553)
---
.../custom-column/custom-column.cy.spec.js | 24 +++++++++----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/frontend/test/metabase/scenarios/custom-column/custom-column.cy.spec.js b/frontend/test/metabase/scenarios/custom-column/custom-column.cy.spec.js
index 034ce056f9f..dd582d75511 100644
--- a/frontend/test/metabase/scenarios/custom-column/custom-column.cy.spec.js
+++ b/frontend/test/metabase/scenarios/custom-column/custom-column.cy.spec.js
@@ -434,18 +434,17 @@ describe("scenarios > question > custom column", () => {
cy.findByText("No discount");
});
- it.skip("should work with relative date filter applied to a custom column (metabase#16273)", () => {
+ it("should work with relative date filter applied to a custom column (metabase#16273)", () => {
openOrdersTable({ mode: "notebook" });
cy.findByText("Custom column").click();
- popover().within(() => {
- cy.get("[contenteditable='true']")
- .type("case([Discount] >0, [Created At], [Product → Created At])")
- .blur();
- cy.findByPlaceholderText("Something nice and descriptive").type(
- "MiscDate",
- );
- cy.button("Done").click();
+
+ enterCustomColumnDetails({
+ formula: `case([Discount] > 0, [Created At], [Product → Created At])`,
+ name: "MiscDate",
});
+
+ cy.button("Done").click();
+
cy.findByText("Filter").click();
popover()
.contains("MiscDate")
@@ -456,10 +455,11 @@ describe("scenarios > question > custom column", () => {
cy.findByText("Years").click();
cy.button("Add filter").click();
- visualize(response => {
- expect(response.body.error).to.not.exist;
+ visualize(({ body }) => {
+ expect(body.error).to.not.exist;
});
- cy.findByText("MiscDate");
+ cy.findByText("MiscDate Previous 30 Years"); // Filter name
+ cy.findByText("MiscDate"); // Column name
});
});
--
GitLab