From 0c4881cddcc579008ed43cfceb783ddbfc591476 Mon Sep 17 00:00:00 2001
From: Walter Leibbrandt <23798+walterl@users.noreply.github.com>
Date: Tue, 3 Dec 2019 00:32:48 +0200
Subject: [PATCH] Warn when asking radio's to underline with no value (#11423)
---
frontend/src/metabase/components/Radio.jsx | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/frontend/src/metabase/components/Radio.jsx b/frontend/src/metabase/components/Radio.jsx
index 9759b9766fa..b1a65e4fa60 100644
--- a/frontend/src/metabase/components/Radio.jsx
+++ b/frontend/src/metabase/components/Radio.jsx
@@ -62,6 +62,12 @@ export default class Radio extends Component {
? [UnderlinedList, UnderlinedItem]
: [NormalList, NormalItem];
+ if (underlined && value === undefined) {
+ console.warn(
+ "Radio can't underline selected option when no value is given.",
+ );
+ }
+
return (
<List {...props} vertical={vertical} showButtons={showButtons}>
{options.map((option, index) => {
--
GitLab