From 0e0cee47f9a0be672d149eb051f4610b2c0527ba Mon Sep 17 00:00:00 2001
From: Gustavo Saiani <gus@metabase.com>
Date: Wed, 16 Nov 2022 14:58:39 -0300
Subject: [PATCH] Move metadata selector test (#26506)
---
.../lib/metadata/Metadata.unit.spec.js | 24 -------------------
.../metabase/selectors/metadata.unit.spec.js | 22 +++++++++++++++++
2 files changed, 22 insertions(+), 24 deletions(-)
delete mode 100644 frontend/test/metabase-lib/lib/metadata/Metadata.unit.spec.js
diff --git a/frontend/test/metabase-lib/lib/metadata/Metadata.unit.spec.js b/frontend/test/metabase-lib/lib/metadata/Metadata.unit.spec.js
deleted file mode 100644
index 87176bca35b..00000000000
--- a/frontend/test/metabase-lib/lib/metadata/Metadata.unit.spec.js
+++ /dev/null
@@ -1,24 +0,0 @@
-import { state } from "__support__/sample_database_fixture";
-
-import { getMetadata } from "metabase/selectors/metadata";
-
-describe("databasesList", () => {
- it("should filter out saved questions", () => {
- const metadata = getMetadata(state);
- const savedQuestionDb = {
- id: "saved-question-id",
- name: "Saved Questions",
- is_saved_questions: true,
- };
- metadata.databases[savedQuestionDb.id] = savedQuestionDb;
-
- expect(
- metadata.databasesList().find(d => d.name === "Saved Questions"),
- ).toEqual(savedQuestionDb);
- expect(
- metadata
- .databasesList({ savedQuestions: false })
- .find(d => d.name === "Saved Questions"),
- ).toBeUndefined();
- });
-});
diff --git a/frontend/test/metabase/selectors/metadata.unit.spec.js b/frontend/test/metabase/selectors/metadata.unit.spec.js
index 11bc8afbfce..58ba198d95a 100644
--- a/frontend/test/metabase/selectors/metadata.unit.spec.js
+++ b/frontend/test/metabase/selectors/metadata.unit.spec.js
@@ -6,6 +6,7 @@ import {
} from "__support__/sample_database_fixture";
import {
copyObjects,
+ getMetadata,
instantiateDatabase,
instantiateSchema,
instantiateTable,
@@ -156,3 +157,24 @@ describe("instantiateQuestion", () => {
expect(instance.metadata()).toBe(metadata);
});
});
+
+describe("databasesList", () => {
+ it("should filter out saved questions", () => {
+ const metadata = getMetadata(state);
+ const savedQuestionDb = {
+ id: "saved-question-id",
+ name: "Saved Questions",
+ is_saved_questions: true,
+ };
+ metadata.databases[savedQuestionDb.id] = savedQuestionDb;
+
+ expect(
+ metadata.databasesList().find(d => d.name === "Saved Questions"),
+ ).toEqual(savedQuestionDb);
+ expect(
+ metadata
+ .databasesList({ savedQuestions: false })
+ .find(d => d.name === "Saved Questions"),
+ ).toBeUndefined();
+ });
+});
--
GitLab