From 0e5230ea0f3a974fd87da2cf1c6475abc05d04d0 Mon Sep 17 00:00:00 2001
From: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Date: Wed, 16 Jun 2021 15:39:32 +0200
Subject: [PATCH] #16555 Repro: Collections appear in items list for user with
revoked access to collections (#16624)
* Add repro for #16555
* Extract common logic into variables
* Update the assertion
---
.../scenarios/collections/collections.cy.spec.js | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/frontend/test/metabase/scenarios/collections/collections.cy.spec.js b/frontend/test/metabase/scenarios/collections/collections.cy.spec.js
index 2fe76f2cae2..3ea982c55b0 100644
--- a/frontend/test/metabase/scenarios/collections/collections.cy.spec.js
+++ b/frontend/test/metabase/scenarios/collections/collections.cy.spec.js
@@ -252,6 +252,9 @@ describe("scenarios > collection_defaults", () => {
});
describe("nested collections with revoked parent access", () => {
+ const { first_name, last_name } = nocollection;
+ const revokedUsersPersonalCollectionName = `${first_name} ${last_name}'s Personal Collection`;
+
beforeEach(() => {
// Create Parent collection within `Our analytics`
cy.request("POST", "/api/collection", {
@@ -288,6 +291,12 @@ describe("scenarios > collection_defaults", () => {
cy.signIn("nocollection");
});
+ it.skip("should not render collections in items list if user doesn't have collection access (metabase#16555)", () => {
+ cy.visit("/collection/root");
+ // Since this user doesn't have access rights to the root collection, it should render empty
+ cy.findByText("Nothing to see yet.");
+ });
+
it("should see a child collection in a sidebar even with revoked access to its parent (metabase#14114)", () => {
cy.visit("/");
cy.findByText("Child");
@@ -303,14 +312,10 @@ describe("scenarios > collection_defaults", () => {
});
it.skip("should be able to choose a child collection when saving a question (metabase#14052)", () => {
- const { first_name, last_name } = nocollection;
-
openOrdersTable();
cy.findByText("Save").click();
// Click to choose which collection should this question be saved to
- cy.findByText(
- `${first_name} ${last_name}'s Personal Collection`,
- ).click();
+ cy.findByText(revokedUsersPersonalCollectionName).click();
popover().within(() => {
cy.findByText(/Our analytics/i);
cy.findByText(/My personal collection/i);
--
GitLab