diff --git a/.eslintrc b/.eslintrc index b63f58f67ac26462a68516f4446815b16932e0be..cea021514b4de2c915457e48cb469a8333fc45d1 100644 --- a/.eslintrc +++ b/.eslintrc @@ -42,7 +42,14 @@ "orderImportKind": "asc", "caseInsensitive": false }, - "groups": ["builtin", "external", "internal", "parent", "sibling", "index"], + "groups": [ + "builtin", + "external", + "internal", + "parent", + "sibling", + "index" + ], "warnOnUnassignedImports": false } ], @@ -193,7 +200,10 @@ "*.unit.spec.jsx" ], "rules": { - "jest/valid-title": ["error", { "ignoreTypeOfDescribeName": true }] + "jest/valid-title": ["error", { "ignoreTypeOfDescribeName": true }], + // In unit tests, you should use `act(() => {})` to invoke things causing state updates + // and rerenders to remove lengthy warnings from jest. Disabling the rule allows this. + "testing-library/no-unnecessary-act": "off" } } ] diff --git a/frontend/src/metabase/querying/components/FilterPicker/FilterPicker.unit.spec.tsx b/frontend/src/metabase/querying/components/FilterPicker/FilterPicker.unit.spec.tsx index 483ef257cabd793e020cc6eb3fad78efb9130b6a..a702e13750912eb31fdd4a54245d7519944d2962 100644 --- a/frontend/src/metabase/querying/components/FilterPicker/FilterPicker.unit.spec.tsx +++ b/frontend/src/metabase/querying/components/FilterPicker/FilterPicker.unit.spec.tsx @@ -403,7 +403,6 @@ describe("FilterPicker", () => { // The expression editor applies changes on blur, // but for some reason it doesn't work without `act`. - // eslint-disable-next-line testing-library/no-unnecessary-act await act(async () => { await userEvent.type(input, text, { delay }); await userEvent.tab();