From 10ec79a38e455d60cfb6f6e818d54fd476267dcb Mon Sep 17 00:00:00 2001 From: Cam Saul <cam@geotip.com> Date: Mon, 3 Aug 2015 18:34:20 -0700 Subject: [PATCH] cleanup metabase.driver/available-drivers :smirk: --- circle.yml | 1 + src/metabase/driver.clj | 15 +++++---------- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/circle.yml b/circle.yml index f46251f1f93..b78a411154a 100644 --- a/circle.yml +++ b/circle.yml @@ -11,6 +11,7 @@ dependencies: - pip install awscli==1.7.3 database: post: + # MySQL doesn't load named timezone information automatically, you have to run this command to load it - mysql_tzinfo_to_sql /usr/share/zoneinfo | mysql -u ubuntu mysql test: override: diff --git a/src/metabase/driver.clj b/src/metabase/driver.clj index 27758589d1d..cce0b650201 100644 --- a/src/metabase/driver.clj +++ b/src/metabase/driver.clj @@ -20,20 +20,15 @@ ;; ## Constants (def ^:const available-drivers - "DB drivers that are available as a dictionary. Each key is a driver with dictionary of attributes. - ex: `:h2 {:id \"h2\" :name \"H2\"}`" + "Available DB drivers." {:h2 {:id "h2" - :name "H2" - :example "file:[filename]"} + :name "H2"} :postgres {:id "postgres" - :name "Postgres" - :example "host=[ip address] port=5432 dbname=examples user=corvus password=******"} + :name "Postgres"} :mongo {:id "mongo" - :name "MongoDB" - :example "mongodb://password:username@127.0.0.1:27017/db-name"} + :name "MongoDB"} :mysql {:id "mysql" - :name "MySQL" - :example "N/A"}}) ; TODO - we don't use connection strings any more so we shouldn't define example ones (!) + :name "MySQL"}}) (defn class->base-type "Return the `Field.base_type` that corresponds to a given class returned by the DB." -- GitLab