From 14b3825363f0619354d2526307d950608baf5618 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cam=20Sa=C3=BCl?= <cammsaul@gmail.com> Date: Tue, 10 Jan 2017 13:41:27 -0800 Subject: [PATCH] Fix rare "device" busy error when building DMG :yum: [ci skip] --- bin/osx-release | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bin/osx-release b/bin/osx-release index 0fb2d00c3ee..868747e5ccc 100755 --- a/bin/osx-release +++ b/bin/osx-release @@ -171,7 +171,7 @@ sub edit_release_notes { remove_tree($release_notes); copy(get_file_or_die('bin/templates/release-notes.html.template'), $release_notes) or die $!; - system('emacs', '-nw', get_file_or_die($release_notes)) == 0 or die $!; + system('nano', get_file_or_die($release_notes)) == 0 or die $!; } @@ -247,6 +247,9 @@ sub finalize_dmg { system('sync'); system('sync'); + # wait a few seconds for the sync to complete so DMG isn't "busy" when we try to unmount it + system('sleep', '5'); + # unmount the temp DMG announce "Unmounting $device..."; system('hdiutil', 'detach', $device) == 0 or die $!; @@ -297,7 +300,7 @@ sub announce_on_slack { Readonly my $slack_url => config('slackWebhookURL') or return; Readonly my $version => version(); Readonly my $awsURL => 'https://s3.amazonaws.com/' . config('awsBucket') . '/' . upload_subdir() . '/Metabase.dmg'; - my $text = "Metabase OS X $version 'Tumultuous Toucan' Is Now Available!\n\n" . + my $text = "Metabase OS X $version 'Complexity-Embracing Toucan' Is Now Available!\n\n" . "Get it here: $awsURL\n\n"; open(my $file, get_file_or_die($release_notes)) or die $!; -- GitLab