From 15909fc321a805980f2bc3f372d41fc0d0c188d4 Mon Sep 17 00:00:00 2001
From: Cal Herries <39073188+calherries@users.noreply.github.com>
Date: Tue, 20 Sep 2022 22:14:30 +0200
Subject: [PATCH] Fix #25521: 403 page when visiting question's URL with a card
template tag (#25525)
* Fix bug
* Update frontend/src/metabase/query_builder/actions/core/parameterUtils.ts
Co-authored-by: Gustavo Saiani <gustavo@poe.ma>
Co-authored-by: Gustavo Saiani <gustavo@poe.ma>
---
.../src/metabase/query_builder/actions/core/parameterUtils.ts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts b/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts
index 3f47cf337c9..2df6bae8631 100644
--- a/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts
+++ b/frontend/src/metabase/query_builder/actions/core/parameterUtils.ts
@@ -128,7 +128,7 @@ export async function handleDashboardParameters(
deserializedCard,
originalCard,
});
- if (shouldPropagateParameters && deserializedCard) {
+ if (shouldPropagateParameters && deserializedCard?.dashcardId) {
const { dashboardId, dashcardId, parameters } = deserializedCard;
const metadata = getMetadata(getState());
await verifyMatchingDashcardAndParameters({
--
GitLab