From 159b117b34212258c67cd00472e8d4634b6f84f1 Mon Sep 17 00:00:00 2001
From: Kyle Doherty <kdoh@users.noreply.github.com>
Date: Wed, 18 Dec 2019 13:30:20 -0500
Subject: [PATCH] use case insensitive sorting on strings in TableSimple
(#11541)
Fixes #11338
---
.../metabase/visualizations/components/TableSimple.jsx | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/frontend/src/metabase/visualizations/components/TableSimple.jsx b/frontend/src/metabase/visualizations/components/TableSimple.jsx
index f962604e0e8..b0847ea9a77 100644
--- a/frontend/src/metabase/visualizations/components/TableSimple.jsx
+++ b/frontend/src/metabase/visualizations/components/TableSimple.jsx
@@ -109,7 +109,14 @@ export default class TableSimple extends Component {
let rowIndexes = _.range(0, rows.length);
if (sortColumn != null) {
- rowIndexes = _.sortBy(rowIndexes, rowIndex => rows[rowIndex][sortColumn]);
+ rowIndexes = _.sortBy(rowIndexes, rowIndex => {
+ let value = rows[rowIndex][sortColumn];
+ // for strings we should be case insensitive
+ if (typeof value === "string") {
+ value = value.toLowerCase();
+ }
+ return value;
+ });
if (sortDescending) {
rowIndexes.reverse();
}
--
GitLab