From 195f9f216a5ea6fe22f67b36306c68779dc19024 Mon Sep 17 00:00:00 2001
From: Alexander Polyankin <alexander.polyankin@metabase.com>
Date: Fri, 6 May 2022 18:53:31 +0300
Subject: [PATCH] Revert "Fix visualization settings for raw tables (#22422)"
(#22493)
---
.../src/metabase/query_builder/selectors.js | 3 +-
.../22359-raw-tables-vis-settings.cy.spec.js | 47 -------------------
2 files changed, 1 insertion(+), 49 deletions(-)
delete mode 100644 frontend/test/metabase/scenarios/visualizations/reproductions/22359-raw-tables-vis-settings.cy.spec.js
diff --git a/frontend/src/metabase/query_builder/selectors.js b/frontend/src/metabase/query_builder/selectors.js
index 444b9ef68d5..3bedb3439d0 100644
--- a/frontend/src/metabase/query_builder/selectors.js
+++ b/frontend/src/metabase/query_builder/selectors.js
@@ -558,8 +558,7 @@ export const getRawSeries = createSelector(
if (isShowingRawTable) {
display = "table";
- settings = _.pick(settings, "column_settings");
- settings = { "table.pivot": false, ...settings };
+ settings = { "table.pivot": false };
}
// we want to provide the visualization with a card containing the latest
diff --git a/frontend/test/metabase/scenarios/visualizations/reproductions/22359-raw-tables-vis-settings.cy.spec.js b/frontend/test/metabase/scenarios/visualizations/reproductions/22359-raw-tables-vis-settings.cy.spec.js
deleted file mode 100644
index 60f629f3e05..00000000000
--- a/frontend/test/metabase/scenarios/visualizations/reproductions/22359-raw-tables-vis-settings.cy.spec.js
+++ /dev/null
@@ -1,47 +0,0 @@
-import { popover, restore, visitQuestionAdhoc } from "__support__/e2e/cypress";
-
-import { SAMPLE_DATABASE } from "__support__/e2e/cypress_sample_database";
-
-const { ORDERS, ORDERS_ID } = SAMPLE_DATABASE;
-
-const questionDetails = {
- name: "21973",
- display: "line",
- dataset_query: {
- type: "query",
- database: 1,
- query: {
- "source-table": ORDERS_ID,
- aggregation: [["count"]],
- breakout: [["field", ORDERS.CREATED_AT, { "temporal-unit": "month" }]],
- },
- },
- visualization_settings: {
- "graph.metrics": ["count"],
- "graph.dimensions": ["CREATED_AT"],
- },
-};
-
-describe("issue 22359", () => {
- beforeEach(() => {
- restore();
- cy.signInAsAdmin();
- });
-
- it("should use visualization settings when viewing raw table data (metabase#22359)", () => {
- visitQuestionAdhoc(questionDetails);
- cy.icon("table2").click();
- cy.findByText("Settings").click();
-
- cy.findByTestId("sidebar-left").within(() => {
- cy.findByText("Data").click();
- cy.findByText("X-axis")
- .parent()
- .within(() => cy.icon("gear").click());
- cy.findByText("January, 2018").click();
- });
-
- popover().within(() => cy.findByText("1/2018").click());
- cy.findByText("4/2016").should("be.visible");
- });
-});
--
GitLab