From 1b28389c800b37725dfb6265ce60b1678b8bf692 Mon Sep 17 00:00:00 2001
From: Romeo Van Snick <romeo@romeovansnick.be>
Date: Wed, 9 Oct 2024 11:12:22 +0200
Subject: [PATCH] Metrics empty copy (#48449)

* Update copy on metrics page

* Update copy in empty metric builder

* Fix e2e test
---
 e2e/test/scenarios/metrics/browse.cy.spec.ts                | 4 ++--
 frontend/src/metabase/browse/metrics/BrowseMetrics.tsx      | 4 ++--
 .../src/metabase/browse/metrics/BrowseMetrics.unit.spec.tsx | 2 +-
 .../MetricEmptyState/MetricEmptyState.tsx                   | 6 +++---
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/e2e/test/scenarios/metrics/browse.cy.spec.ts b/e2e/test/scenarios/metrics/browse.cy.spec.ts
index 27ddb7d3149..55834279e7a 100644
--- a/e2e/test/scenarios/metrics/browse.cy.spec.ts
+++ b/e2e/test/scenarios/metrics/browse.cy.spec.ts
@@ -113,7 +113,7 @@ describe("scenarios > browse > metrics", () => {
       cy.visit("/browse/metrics");
       main()
         .findByText(
-          "Metrics help you summarize and analyze your data effortlessly.",
+          "Create Metrics to define the official way to calculate important numbers for your team",
         )
         .should("be.visible");
     });
@@ -279,7 +279,7 @@ describe("scenarios > browse > metrics", () => {
 
       main()
         .findByText(
-          "Metrics help you summarize and analyze your data effortlessly.",
+          "Create Metrics to define the official way to calculate important numbers for your team",
         )
         .should("be.visible");
 
diff --git a/frontend/src/metabase/browse/metrics/BrowseMetrics.tsx b/frontend/src/metabase/browse/metrics/BrowseMetrics.tsx
index 66264f2a439..b5af1d99dbf 100644
--- a/frontend/src/metabase/browse/metrics/BrowseMetrics.tsx
+++ b/frontend/src/metabase/browse/metrics/BrowseMetrics.tsx
@@ -88,9 +88,9 @@ export function BrowseMetrics() {
 function MetricsEmptyState() {
   return (
     <Flex align="center" justify="center" mih="70vh">
-      <Box maw="25rem">
+      <Box maw="30rem">
         <EmptyState
-          title={t`Metrics help you summarize and analyze your data effortlessly.`}
+          title={t`Create Metrics to define the official way to calculate important numbers for your team`}
           message={
             <Text mt="sm" maw="25rem">
               {t`Metrics are like pre-defined calculations: create your aggregations once, save them as metrics, and use them whenever you need to analyze your data.`}
diff --git a/frontend/src/metabase/browse/metrics/BrowseMetrics.unit.spec.tsx b/frontend/src/metabase/browse/metrics/BrowseMetrics.unit.spec.tsx
index d7a5c4d28f1..ae42d5608eb 100644
--- a/frontend/src/metabase/browse/metrics/BrowseMetrics.unit.spec.tsx
+++ b/frontend/src/metabase/browse/metrics/BrowseMetrics.unit.spec.tsx
@@ -237,7 +237,7 @@ describe("BrowseMetrics", () => {
     setup({ metricCount: 0 });
     expect(
       await screen.findByText(
-        "Metrics help you summarize and analyze your data effortlessly.",
+        "Create Metrics to define the official way to calculate important numbers for your team",
       ),
     ).toBeInTheDocument();
   });
diff --git a/frontend/src/metabase/querying/metrics/components/MetricEditor/MetricEditorFooter/MetricEmptyState/MetricEmptyState.tsx b/frontend/src/metabase/querying/metrics/components/MetricEditor/MetricEditorFooter/MetricEmptyState/MetricEmptyState.tsx
index 4283bac3f7a..8011e8b3b3e 100644
--- a/frontend/src/metabase/querying/metrics/components/MetricEditor/MetricEditorFooter/MetricEmptyState/MetricEmptyState.tsx
+++ b/frontend/src/metabase/querying/metrics/components/MetricEditor/MetricEditorFooter/MetricEmptyState/MetricEmptyState.tsx
@@ -20,10 +20,10 @@ export function MetricEmptyState({
       data-testid="metric-empty-state"
     >
       <Text mb="sm" fw="bold" fz="lg">
-        {t`A metric is one of the key numbers you want to keep track of`}
+        {t`Create Metrics to define the official way to calculate important numbers for your team`}
       </Text>
-      <Text mb="lg" c="text-medium" maw="28.75rem" align="center">
-        {t`To create one, you’ll need to define how it’s calculated, add any required filters, and optionally pick the main dimension for your metric.`}
+      <Text mb="lg" c="text-medium" maw="30rem" align="center">
+        {t`Metrics are like pre-defined calculations: create your aggregations once, save them as metrics, and use them whenever you need to analyze your data.`}
       </Text>
       {isRunnable && (
         <Button variant="filled" onClick={() => runQuestionQuery()}>
-- 
GitLab