From 1d1d76a174a72910e23c5a08c9a687e14ddf6631 Mon Sep 17 00:00:00 2001
From: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Date: Wed, 6 Jul 2022 12:46:44 +0200
Subject: [PATCH] Repro #23689: Sandboxed group managers can't see other users
in the People tab #23689 (#23710)
---
.../23689-sandboxed-group-manager.cy.spec.js | 77 +++++++++++++++++++
1 file changed, 77 insertions(+)
create mode 100644 frontend/test/metabase/scenarios/admin/people/reproductions/23689-sandboxed-group-manager.cy.spec.js
diff --git a/frontend/test/metabase/scenarios/admin/people/reproductions/23689-sandboxed-group-manager.cy.spec.js b/frontend/test/metabase/scenarios/admin/people/reproductions/23689-sandboxed-group-manager.cy.spec.js
new file mode 100644
index 00000000000..6022e10a59c
--- /dev/null
+++ b/frontend/test/metabase/scenarios/admin/people/reproductions/23689-sandboxed-group-manager.cy.spec.js
@@ -0,0 +1,77 @@
+import { restore, describeEE } from "__support__/e2e/helpers";
+import { USERS, USER_GROUPS } from "__support__/e2e/cypress_data";
+import { SAMPLE_DATABASE } from "__support__/e2e/cypress_sample_database";
+
+const { COLLECTION_GROUP } = USER_GROUPS;
+const { sandboxed, normal, nodata, nocollection } = USERS;
+
+const { ORDERS, ORDERS_ID } = SAMPLE_DATABASE;
+
+const totalUsers = Object.keys(USERS).length;
+
+describeEE("issue 23689", () => {
+ beforeEach(() => {
+ // TODO: remove the next line when this issue gets fixed
+ cy.skipOn(true);
+
+ cy.intercept("GET", "/api/permissions/membership").as("membership");
+
+ restore();
+ cy.signInAsAdmin();
+
+ visitGroupPermissionsPage(COLLECTION_GROUP);
+
+ cy.findByText("3 members");
+
+ findUserByFullName(normal);
+ findUserByFullName(nodata);
+
+ // Make sandboxed user a group manager
+ findUserByFullName(sandboxed)
+ .closest("tr")
+ .findByTestId("user-type-toggle")
+ .click({ force: true });
+
+ // Sanity check instead of waiting for the PUT request
+ cy.findByText("Manager");
+
+ cy.sandboxTable({
+ table_id: ORDERS_ID,
+ attribute_remappings: {
+ attr_uid: ["dimension", ["field", ORDERS.USER_ID, null]],
+ },
+ });
+
+ cy.signOut();
+ cy.signInAsSandboxedUser();
+ });
+
+ it("sandboxed group manager should see all other members (metabase#23689)", () => {
+ visitGroupPermissionsPage(COLLECTION_GROUP);
+
+ cy.findByText("3 members");
+
+ findUserByFullName(sandboxed);
+ findUserByFullName(normal);
+ findUserByFullName(nodata);
+
+ cy.visit("/admin/people");
+ cy.wait("@membership");
+
+ cy.findByText(`${totalUsers} people found`);
+ findUserByFullName(sandboxed);
+ findUserByFullName(normal);
+ findUserByFullName(nodata);
+ findUserByFullName(nocollection);
+ });
+});
+
+function findUserByFullName(user) {
+ const { first_name, last_name } = user;
+ return cy.findByText(`${first_name} ${last_name}`);
+}
+
+function visitGroupPermissionsPage(groupId) {
+ cy.visit(`/admin/people/groups/${groupId}`);
+ cy.wait("@membership");
+}
--
GitLab