diff --git a/frontend/src/metabase-lib/Question.ts b/frontend/src/metabase-lib/Question.ts index 565cdfaf7b9d2925f87140706b89c6669b09440c..fcac701b5badb4a453aa999cbd3db3aec288affa 100644 --- a/frontend/src/metabase-lib/Question.ts +++ b/frontend/src/metabase-lib/Question.ts @@ -272,7 +272,7 @@ class QuestionInner { } isAction() { - return this._card && this._card.is_write; + return false; } setPersisted(isPersisted) { @@ -290,7 +290,7 @@ class QuestionInner { } setIsAction(isAction) { - return this.setCard(assoc(this.card(), "is_write", isAction)); + return this.card(); } // locking the display prevents auto-selection diff --git a/frontend/src/metabase/entities/questions.js b/frontend/src/metabase/entities/questions.js index 0941d500b8a73fb9a91aa2cbf663d7ceb4278343..6d7564601395ed225a6db02de242d16a73609345 100644 --- a/frontend/src/metabase/entities/questions.js +++ b/frontend/src/metabase/entities/questions.js @@ -113,7 +113,6 @@ const Questions = createEntity({ "collection_position", "collection_preview", "result_metadata", - "is_write", ], getAnalyticsMetadata([object], { action }, getState) { diff --git a/frontend/src/metabase/entities/questions/forms.js b/frontend/src/metabase/entities/questions/forms.js index 12157ec36fa82dc643f5f689c498c5933dabeb68..748952f403b57a1b22052b8b939f97ab71005eed 100644 --- a/frontend/src/metabase/entities/questions/forms.js +++ b/frontend/src/metabase/entities/questions/forms.js @@ -13,12 +13,6 @@ const FORM_FIELDS = [ type: "text", placeholder: t`It's optional but oh, so helpful`, }, - { - name: "is_write", - title: t`Is Write`, - description: t`Write questions can be used for experimental actions.`, - type: "boolean", - }, ]; export default { diff --git a/frontend/src/metabase/query_builder/components/QuestionActions.tsx b/frontend/src/metabase/query_builder/components/QuestionActions.tsx index 334924efe5be86eec8ee014d9d2a831b3270575f..3931c05178564b5aae0ed1f05a778fc3bf53062e 100644 --- a/frontend/src/metabase/query_builder/components/QuestionActions.tsx +++ b/frontend/src/metabase/query_builder/components/QuestionActions.tsx @@ -73,8 +73,6 @@ const QuestionActions = ({ question, setQueryBuilderMode, turnDatasetIntoQuestion, - turnQuestionIntoAction, - turnActionIntoQuestion, onInfoClick, onModelPersistenceChange, isModerator, @@ -86,7 +84,6 @@ const QuestionActions = ({ ? color("brand") : undefined; - const isAction = question.isAction(); const isDataset = question.isDataset(); const canWrite = question.canWrite(); const isSaved = question.isSaved(); @@ -169,7 +166,7 @@ const QuestionActions = ({ action: () => onOpenModal(MODAL_TYPES.MOVE), testId: MOVE_TESTID, }); - if (!isDataset && !isAction) { + if (!isDataset) { extraButtons.push({ title: t`Turn into a model`, icon: "model", @@ -184,15 +181,6 @@ const QuestionActions = ({ action: turnDatasetIntoQuestion, }); } - if (isSaved && isNative && !isDataset) { - extraButtons.push({ - title: isAction - ? t`Turn back to saved question` - : t`Turn into an action`, - icon: "bolt", - action: isAction ? turnActionIntoQuestion : turnQuestionIntoAction, - }); - } } if (!question.query().readOnly()) {