From 22b889b431c0b38185b2f72ff0fb942748195aef Mon Sep 17 00:00:00 2001
From: Ngoc Khuat <qn.khuat@gmail.com>
Date: Fri, 24 Feb 2023 19:46:04 +0700
Subject: [PATCH] we don't need serdes for parameter card because it'll be
recreatred on laod (#28596)
---
src/metabase/models/parameter_card.clj | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/src/metabase/models/parameter_card.clj b/src/metabase/models/parameter_card.clj
index 5fd90e62cdb..aad2454f0f5 100644
--- a/src/metabase/models/parameter_card.clj
+++ b/src/metabase/models/parameter_card.clj
@@ -1,8 +1,6 @@
(ns metabase.models.parameter-card
(:require
[metabase.models.interface :as mi]
- [metabase.models.serialization.base :as serdes.base]
- [metabase.models.serialization.util :as serdes.util]
[metabase.util :as u]
[metabase.util.i18n :refer [tru]]
[metabase.util.malli :as mu]
@@ -76,18 +74,3 @@
upsertable-parameters (filter upsertable? parameters)]
(upsert-from-parameters! parameterized-object-type parameterized-object-id upsertable-parameters)
(delete-all-for-parameterized-object! parameterized-object-type parameterized-object-id (map :id upsertable-parameters))))
-
-;;; ----------------------------------------------- SERIALIZATION ----------------------------------------------------
-;; ParameterCard are not serialized as their own, separate entities. They are inlined onto their parent ParameterizedObjects
-
-(defmethod serdes.base/load-xform "ParameterCard"
- [parameter-card]
- (let [parameterized-model (case (:parameterized_object_type parameter-card)
- "dashboard" 'Dashboard
- "card" 'Card)]
- (-> parameter-card
- (dissoc :serdes/meta)
- (update :card_id serdes.util/import-fk 'Card)
- (update :parameterized_object_id serdes.util/import-fk parameterized-model)
- (update :parameter_mappings serdes.util/import-parameter-mappings)
- (update :visualization_settings serdes.util/import-visualization-settings))))
--
GitLab