From 24ceb953ee4a0e74fb2931ca561e283d94c733ae Mon Sep 17 00:00:00 2001
From: Tom Robinson <tlrobinson@gmail.com>
Date: Wed, 28 Dec 2016 15:04:51 -0800
Subject: [PATCH] Comment settings.spec.js
---
frontend/test/e2e/admin/settings.spec.js | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/frontend/test/e2e/admin/settings.spec.js b/frontend/test/e2e/admin/settings.spec.js
index 142fa205697..8960e4f39f5 100644
--- a/frontend/test/e2e/admin/settings.spec.js
+++ b/frontend/test/e2e/admin/settings.spec.js
@@ -13,17 +13,24 @@ describeE2E("admin/settings", () => {
describe("admin settings", () => {
it("should persist a setting", async () => {
+ // pick a random site name to try updating it to
const siteName = "Metabase" + Math.random();
+ // load the "general" pane of the admin settings
await d.get(`${server.host}/admin/settings/general`);
+ // first just make sure the site name isn't already set (it shouldn't since we're using a random name)
expect(await d.select(".SettingsInput").wait().attribute("value")).not.toBe(siteName);
+ // clear the site name input, send the keys corresponding to the site name, then blur to trigger the update
await d.select(".SettingsInput").wait().clear().sendKeys(siteName).blur();
+ // wait for the loading indicator to show success
await d.select(".SaveStatus.text-success").wait();
+ // reload the page
await d.get(`${server.host}/admin/settings/general`);
+ // verify the site name value was persisted
expect(await d.select(".SettingsInput").wait().attribute("value")).toBe(siteName);
});
});
--
GitLab