diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingsTableFormatting.jsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingsTableFormatting.jsx index f6628a64d1d8c07344662cee96bf6e68bbf15517..00cf6bb71b7458732ad9a58970b185a889b34b57 100644 --- a/frontend/src/metabase/visualizations/components/settings/ChartSettingsTableFormatting.jsx +++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingsTableFormatting.jsx @@ -376,6 +376,7 @@ const RuleEditor = ({ type="number" value={rule.value} onChange={value => onChange({ ...rule, value })} + placeholder="0" /> ) : hasOperand ? ( <input @@ -383,6 +384,7 @@ const RuleEditor = ({ className={INPUT_CLASSNAME} value={rule.value} onChange={e => onChange({ ...rule, value: e.target.value })} + placeholder={t`Column value`} /> ) : null} <h3 className="mt3 mb1">{t`…turn its background this color:`}</h3> diff --git a/frontend/src/metabase/visualizations/lib/settings/column.js b/frontend/src/metabase/visualizations/lib/settings/column.js index e7a5f6406462843cfe6c455d70d69cbfae7bd552..1519ce26a59994030df372864a1881cd607de0fa 100644 --- a/frontend/src/metabase/visualizations/lib/settings/column.js +++ b/frontend/src/metabase/visualizations/lib/settings/column.js @@ -390,6 +390,9 @@ export const NUMBER_COLUMN_SETTINGS = { title: t`Minimum number of decimal places`, widget: "number", variant: "form-field", + props: { + placeholder: "1", + }, }, scale: { title: t`Multiply by a number`, @@ -403,11 +406,17 @@ export const NUMBER_COLUMN_SETTINGS = { title: t`Add a prefix`, widget: "input", variant: "form-field", + props: { + placeholder: "$", + }, }, suffix: { title: t`Add a suffix`, widget: "input", variant: "form-field", + props: { + placeholder: t`dollars`, + }, }, // Optimization: build a single NumberFormat object that is used by formatting.js _numberFormatter: { diff --git a/frontend/src/metabase/visualizations/visualizations/List.tsx b/frontend/src/metabase/visualizations/visualizations/List.tsx index 6609a3f5f6d1c1b1ab6eb66128f749347562b728..3326f10922d21fd8457f825f65bcc1e22b2e721a 100644 --- a/frontend/src/metabase/visualizations/visualizations/List.tsx +++ b/frontend/src/metabase/visualizations/visualizations/List.tsx @@ -177,6 +177,9 @@ export default Object.assign(ListViz, { getHidden: (_: unknown, settings: VisualizationSettings) => settings["view_as"] !== "link" && settings["view_as"] !== "email_link", readDependencies: ["view_as"], + props: { + placeholder: t`Link to {{bird_id}}`, + }, }; settings["link_url"] = { @@ -187,6 +190,9 @@ export default Object.assign(ListViz, { getHidden: (_: unknown, settings: VisualizationSettings) => settings["view_as"] !== "link", readDependencies: ["view_as"], + props: { + placeholder: t`http://toucan.example/{{bird_id}}`, + }, }; return settings; diff --git a/frontend/src/metabase/visualizations/visualizations/Table.jsx b/frontend/src/metabase/visualizations/visualizations/Table.jsx index ba91cf01a8e61f18c3481edadbd8044ec4b4e175..d05056c4d2c0b438f185cdf7235b79494d9ab419 100644 --- a/frontend/src/metabase/visualizations/visualizations/Table.jsx +++ b/frontend/src/metabase/visualizations/visualizations/Table.jsx @@ -292,6 +292,9 @@ export default class Table extends Component { getHidden: (_, settings) => settings["view_as"] !== "link" && settings["view_as"] !== "email_link", readDependencies: ["view_as"], + props: { + placeholder: t`Link to {{bird_id}}`, + }, }; settings["link_url"] = { @@ -301,6 +304,9 @@ export default class Table extends Component { default: null, getHidden: (_, settings) => settings["view_as"] !== "link", readDependencies: ["view_as"], + props: { + placeholder: t`http://toucan.example/{{bird_id}}`, + }, }; return settings;