From 2f95ef01854ac57c57ff46af09964e86cfdf0cc3 Mon Sep 17 00:00:00 2001
From: Cam Saul <1455846+camsaul@users.noreply.github.com>
Date: Wed, 2 Aug 2023 08:56:41 -0700
Subject: [PATCH] Remove unused `GET
/api/database/db-ids-with-deprecated-drivers` endpoint (#32710)
---
frontend/src/metabase/services.js | 1 -
src/metabase/api/database.clj | 12 ------------
test/metabase/api/database_test.clj | 10 ----------
3 files changed, 23 deletions(-)
diff --git a/frontend/src/metabase/services.js b/frontend/src/metabase/services.js
index 73ca1894bde..baa3453cbae 100644
--- a/frontend/src/metabase/services.js
+++ b/frontend/src/metabase/services.js
@@ -340,7 +340,6 @@ export const MetabaseApi = {
db_discard_values: POST("/api/database/:dbId/discard_values"),
db_persist: POST("/api/database/:dbId/persist"),
db_unpersist: POST("/api/database/:dbId/unpersist"),
- db_get_db_ids_with_deprecated_drivers: GET("/db-ids-with-deprecated-drivers"),
db_usage_info: GET("/api/database/:dbId/usage_info"),
table_list: GET("/api/table"),
// table_get: GET("/api/table/:tableId"),
diff --git a/src/metabase/api/database.clj b/src/metabase/api/database.clj
index 152f8c6c34f..9b227336bc9 100644
--- a/src/metabase/api/database.clj
+++ b/src/metabase/api/database.clj
@@ -1179,16 +1179,4 @@
[:in :collection_id (api/check-404 (not-empty (t2/select-pks-set Collection :name schema)))])])
(map api.table/card->virtual-table))))
-(api/defendpoint GET "/db-ids-with-deprecated-drivers"
- "Return a list of database IDs using currently deprecated drivers."
- []
- (map
- u/the-id
- (filter
- (fn [database]
- (let [info (driver.u/available-drivers-info)
- d (driver.u/database->driver database)]
- (some? (:superseded-by (d info)))))
- (t2/select-pks-set Database))))
-
(api/define-routes)
diff --git a/test/metabase/api/database_test.clj b/test/metabase/api/database_test.clj
index 449e7a238d2..2224c288443 100644
--- a/test/metabase/api/database_test.clj
+++ b/test/metabase/api/database_test.clj
@@ -1512,16 +1512,6 @@
:refresh-token protected-password})))))
-(deftest db-ids-with-deprecated-drivers-test
- (mt/with-driver :driver-deprecation-test-legacy
- (testing "GET /api/database/db-ids-with-deprecated-drivers"
- (t2.with-temp/with-temp [Database {db-id :id} {:engine :driver-deprecation-test-legacy}]
- (is (not-empty (filter #(= % db-id) (mt/user-http-request
- :crowberto
- :get
- 200
- "database/db-ids-with-deprecated-drivers"))))))))
-
(deftest secret-file-paths-returned-by-api-test
(mt/with-driver :secret-test-driver
(testing "File path values for secrets are returned as plaintext in the API (#20030)"
--
GitLab