From 320307f76534199ac0416eeacd13bd05a02a1db5 Mon Sep 17 00:00:00 2001
From: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
Date: Wed, 17 Apr 2024 15:26:11 +0300
Subject: [PATCH] Remove not flaky tests from flaky group (#41496)
---
...ack-navigation-preserve-filters.cy.spec.js | 56 +++++++++----------
.../drillthroughs/chart_drill.cy.spec.js | 2 +-
2 files changed, 27 insertions(+), 31 deletions(-)
diff --git a/e2e/test/scenarios/dashboard/reproductions/34382-dashboard-back-navigation-preserve-filters.cy.spec.js b/e2e/test/scenarios/dashboard/reproductions/34382-dashboard-back-navigation-preserve-filters.cy.spec.js
index 39446dc8dd1..d851697d4cf 100644
--- a/e2e/test/scenarios/dashboard/reproductions/34382-dashboard-back-navigation-preserve-filters.cy.spec.js
+++ b/e2e/test/scenarios/dashboard/reproductions/34382-dashboard-back-navigation-preserve-filters.cy.spec.js
@@ -21,36 +21,32 @@ describe("issue 34382", () => {
);
});
- it(
- "should preserve filter value when navigating between the dashboard and the query builder with auto-apply disabled (metabase#34382)",
- { tags: "@flaky" },
- () => {
- createDashboardWithCards();
- visitDashboard("@dashboardId");
-
- addFilterValue("Gizmo");
- applyFilter();
-
- cy.log("Navigate to Products question");
- getDashboardCard().findByText("Products").click();
-
- cy.log("Navigate back to dashboard");
- queryBuilderHeader()
- .findByLabelText("Back to Products in a dashboard")
- .click();
-
- cy.location("search").should("eq", "?category=Gizmo");
- filterWidget().contains("Gizmo");
-
- getDashboardCard().within(() => {
- // only products with category "Gizmo" are filtered
- cy.findAllByTestId("table-row")
- .find("td")
- .eq(3)
- .should("contain", "Gizmo");
- });
- },
- );
+ it("should preserve filter value when navigating between the dashboard and the query builder with auto-apply disabled (metabase#34382)", () => {
+ createDashboardWithCards();
+ visitDashboard("@dashboardId");
+
+ addFilterValue("Gizmo");
+ applyFilter();
+
+ cy.log("Navigate to Products question");
+ getDashboardCard().findByText("Products").click();
+
+ cy.log("Navigate back to dashboard");
+ queryBuilderHeader()
+ .findByLabelText("Back to Products in a dashboard")
+ .click();
+
+ cy.location("search").should("eq", "?category=Gizmo");
+ filterWidget().contains("Gizmo");
+
+ getDashboardCard().within(() => {
+ // only products with category "Gizmo" are filtered
+ cy.findAllByTestId("table-row")
+ .find("td")
+ .eq(3)
+ .should("contain", "Gizmo");
+ });
+ });
});
const createDashboardWithCards = () => {
diff --git a/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js
index d41757307da..a275945010f 100644
--- a/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js
+++ b/e2e/test/scenarios/visualizations-tabular/drillthroughs/chart_drill.cy.spec.js
@@ -25,7 +25,7 @@ describe("scenarios > visualizations > drillthroughs > chart drill", () => {
cy.signInAsAdmin();
});
- it("should allow brush date filter", { tags: "@flaky" }, () => {
+ it("should allow brush date filter", () => {
cy.createQuestion(
{
name: "Brush Date Temporal Filter",
--
GitLab