From 3384ecbb4c5cb2db6f1e8ee4d7e1130c40df1071 Mon Sep 17 00:00:00 2001
From: Cal Herries <39073188+calherries@users.noreply.github.com>
Date: Mon, 5 Jun 2023 14:27:40 +0300
Subject: [PATCH] Undo renaming `AddJoinAliasToVisualizationSettingsFieldRefs`
migration (#31316)
---
resources/migrations/000_migrations.yaml | 6 +++---
src/metabase/db/custom_migrations.clj | 2 +-
test/metabase/db/custom_migrations_test.clj | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/resources/migrations/000_migrations.yaml b/resources/migrations/000_migrations.yaml
index 57574cd5bf9..37a4dcd58b9 100644
--- a/resources/migrations/000_migrations.yaml
+++ b/resources/migrations/000_migrations.yaml
@@ -14776,7 +14776,7 @@ databaseChangeLog:
- changeSet:
id: v47.00-027
- author: calherres
+ author: calherries
comment: Added 0.47.0 - Migrate field_ref in report_card.result_metadata from legacy format
changes:
- customChange:
@@ -14784,11 +14784,11 @@ databaseChangeLog:
- changeSet:
id: v47.00-028
- author: calherres
+ author: calherries
comment: Added 0.47.0 - Add join-alias to the report_card.visualization_settings.column_settings field refs
changes:
- customChange:
- class: "metabase.db.custom_migrations.AddJoinAliasToColumnSettingsFieldRefs"
+ class: "metabase.db.custom_migrations.AddJoinAliasToVisualizationSettingsFieldRefs"
- changeSet:
id: v47.00-029
diff --git a/src/metabase/db/custom_migrations.clj b/src/metabase/db/custom_migrations.clj
index 14c30806ae3..ea58ef25c47 100644
--- a/src/metabase/db/custom_migrations.clj
+++ b/src/metabase/db/custom_migrations.clj
@@ -288,7 +288,7 @@
_ [[k v]]))
column_settings)))))))
-(define-reversible-migration AddJoinAliasToColumnSettingsFieldRefs
+(define-reversible-migration AddJoinAliasToVisualizationSettingsFieldRefs
(let [update-one! (fn [{:keys [id visualization_settings] :as card}]
(let [updated (add-join-alias-to-column-settings-refs card)]
(when (not= visualization_settings updated)
diff --git a/test/metabase/db/custom_migrations_test.clj b/test/metabase/db/custom_migrations_test.clj
index cb901df5fe8..a7da7343982 100644
--- a/test/metabase/db/custom_migrations_test.clj
+++ b/test/metabase/db/custom_migrations_test.clj
@@ -180,7 +180,7 @@
((:out mi/transform-result-metadata))
json/generate-string)))))))))
-(deftest add-join-alias-to-column-settings-field-refs-test
+(deftest add-join-alias-to-visualization-settings-field-refs-test
(testing "Migrations v47.00-028: update visualization_settings.column_settings legacy field refs"
(impl/test-migrations ["v47.00-028"] [migrate!]
(let [{:keys [db-type ^javax.sql.DataSource data-source]} mdb.connection/*application-db*
--
GitLab