diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ab16313bc1dc712e69492537c8c4532eb909f8e9..1f017188292c35f9cbc84509e90b4151026b493e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,10 +1,24 @@ -###### Before submitting the PR, please make sure you do the following +> **Warning** +> +> If that is your first contribution to Metabase, please sign the [Contributor License Agreement](https://docs.google.com/a/metabase.com/forms/d/1oV38o7b9ONFSwuzwmERRMi9SYrhYeOrkbmNaq9pOJ_E/viewform) (unless it's a tiny documentation change). Also, if you're attempting to fix a translation issue, please submit your changes to our [POEditor project](https://poeditor.com/join/project/ynjQmwSsGh) instead of opening a PR. -- [ ] If you're attempting to fix a translation issue, please submit your changes to our [POEditor project](https://poeditor.com/join/project/ynjQmwSsGh) instead of opening a PR. +Closes https://github.com/metabase/metabase/issues/[issue_number] -### Tests +### Description -- [ ] Run the frontend and Cypress end-to-end tests with `yarn lint && yarn test`) -- [ ] If there are changes to the backend codebase, run the backend tests with `clojure -X:dev:test` -- [ ] Sign the [Contributor License Agreement](https://docs.google.com/a/metabase.com/forms/d/1oV38o7b9ONFSwuzwmERRMi9SYrhYeOrkbmNaq9pOJ_E/viewform) - (unless it's a tiny documentation change). +Describe the overall approach and the problem being solved. + +### How to verify + +Describe the steps to verify that the changes are working as expected. + +1. New question -> Sample Dataset -> ... +2. ... + +### Demo + +_Upload a demo video or before/after screenshots if sensible or remove the section_ + +### Checklist + +- [ ] Tests have been added/updated to cover changes in this PR