From 383c8bed6e5ea901f140c41dfb042a2f7ebd4e28 Mon Sep 17 00:00:00 2001
From: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Date: Mon, 29 May 2023 13:07:46 -0400
Subject: [PATCH] don't try to update recent views if no user-id is passed
(#31103)
---
src/metabase/events/view_log.clj | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/src/metabase/events/view_log.clj b/src/metabase/events/view_log.clj
index 65bbba8659f..09e4439773c 100644
--- a/src/metabase/events/view_log.clj
+++ b/src/metabase/events/view_log.clj
@@ -135,14 +135,15 @@
(defn- update-users-recent-views!
[user-id model model-id]
- (mw.session/with-current-user user-id
- (let [view {:model (name model)
- :model_id model-id}
- prior-views (remove #{view} (user-recent-views))]
- (when (= model "dashboard") (most-recently-viewed-dashboard! model-id))
- (when-not ((set prior-views) view)
- (let [new-views (vec (take 10 (conj prior-views view)))]
- (user-recent-views! new-views))))))
+ (when user-id
+ (mw.session/with-current-user user-id
+ (let [view {:model (name model)
+ :model_id model-id}
+ prior-views (remove #{view} (user-recent-views))]
+ (when (= model "dashboard") (most-recently-viewed-dashboard! model-id))
+ (when-not ((set prior-views) view)
+ (let [new-views (vec (take 10 (conj prior-views view)))]
+ (user-recent-views! new-views)))))))
(defn handle-view-event!
"Handle processing for a single event notification received on the view-log-channel"
--
GitLab