From 38a9eb3a724c46181b1d4a3a50da004a091c16e9 Mon Sep 17 00:00:00 2001
From: Oleksandr Yakushev <alex@bytopia.org>
Date: Wed, 30 Oct 2024 21:52:21 +0200
Subject: [PATCH] [qp] Convert timestamps to strings as the last
post-processing step (#49209)
---
src/metabase/analyze/fingerprint/insights.clj | 2 +-
src/metabase/query_processor/postprocess.clj | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/metabase/analyze/fingerprint/insights.clj b/src/metabase/analyze/fingerprint/insights.clj
index f8d5abd455f..839148e895f 100644
--- a/src/metabase/analyze/fingerprint/insights.clj
+++ b/src/metabase/analyze/fingerprint/insights.clj
@@ -241,7 +241,7 @@
xfn #(nth % x-position)]
(fingerprinters/with-error-handling
((map (fn [row]
- ;; Convert string datetime into days-from-epoch early.
+ ;; Convert string datetimes or Instants into into days-from-epoch early.
(update (vec row) x-position #(some-> %
fingerprinters/->temporal
->millis-from-epoch
diff --git a/src/metabase/query_processor/postprocess.clj b/src/metabase/query_processor/postprocess.clj
index 0575c7f3eb9..accf9ed8754 100644
--- a/src/metabase/query_processor/postprocess.clj
+++ b/src/metabase/query_processor/postprocess.clj
@@ -28,7 +28,8 @@
Where `rff` has the form
(f metadata) -> rf"
- [#'results-metadata/record-and-return-metadata!
+ [#'format-rows/format-rows
+ #'results-metadata/record-and-return-metadata!
#'limit/limit-result-rows
#'qp.middleware.enterprise/limit-download-result-rows
#'qp.add-rows-truncated/add-rows-truncated
@@ -36,7 +37,6 @@
#'qp.middleware.enterprise/merge-sandboxing-metadata
#'qp.add-dimension-projections/remap-results
#'pivot-export/add-data-for-pivot-export
- #'format-rows/format-rows
#'large-int-id/convert-id-to-string
#'viz-settings/update-viz-settings
#'qp.cumulative-aggregations/sum-cumulative-aggregation-columns
--
GitLab