From 3bc645574592231bad1f37aeb6746a9782f0c0cb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Atte=20Kein=C3=A4nen?= <atte.keinanen@gmail.com>
Date: Tue, 9 May 2017 11:54:57 -0700
Subject: [PATCH] Fix Flow code, remove obsolete comments [ci e2e]
---
.../src/metabase/dashboard/containers/DashboardApp.jsx | 8 ++++++--
frontend/src/metabase/dashboard/hoc/DashboardControls.jsx | 2 --
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/frontend/src/metabase/dashboard/containers/DashboardApp.jsx b/frontend/src/metabase/dashboard/containers/DashboardApp.jsx
index 6b25d1ab2f1..9f53afad1f6 100644
--- a/frontend/src/metabase/dashboard/containers/DashboardApp.jsx
+++ b/frontend/src/metabase/dashboard/containers/DashboardApp.jsx
@@ -47,12 +47,16 @@ const mapDispatchToProps = {
onChangeLocation: push
}
+type DashboardAppState = {
+ addCardOnLoad: number|null
+}
+
@connect(mapStateToProps, mapDispatchToProps)
@title(({ dashboard }) => dashboard && dashboard.name)
export default class DashboardApp extends Component {
- state = {
+ state: DashboardAppState = {
addCardOnLoad: null
- }
+ };
componentWillMount() {
let options = parseHashOptions(window.location.hash);
diff --git a/frontend/src/metabase/dashboard/hoc/DashboardControls.jsx b/frontend/src/metabase/dashboard/hoc/DashboardControls.jsx
index 3f2946ea9c7..f291c2a50ad 100644
--- a/frontend/src/metabase/dashboard/hoc/DashboardControls.jsx
+++ b/frontend/src/metabase/dashboard/hoc/DashboardControls.jsx
@@ -86,7 +86,6 @@ export default (ComposedComponent: ReactClass<any>) =>
};
updateDashboardParams = () => {
- // should I do it here?
let options = parseHashOptions(window.location.hash);
const setValue = (name, value) => {
if (value) {
@@ -206,7 +205,6 @@ export default (ComposedComponent: ReactClass<any>) =>
onNightModeChange={this.setNightMode}
onFullscreenChange={this.setFullscreen}
onRefreshPeriodChange={this.setRefreshPeriod}
- addDashboardOnLoad={this.addDashboardOnLoad}
/>
);
}
--
GitLab