From 404680916194f1c53fd6c4b272c69471d61a7093 Mon Sep 17 00:00:00 2001
From: Tim Macdonald <tim@metabase.com>
Date: Tue, 23 Jan 2024 17:12:24 +0000
Subject: [PATCH] Fix one flaky [SparkSQL?] fingerprinting test (#37853)
* Fix flake in fingerprint test:
```
FAIL in metabase.sync.analyze.fingerprint-test/fingerprint-test (fingerprint_test.clj:287)
:sparksql
Fingerprints should actually get saved with the correct values Text fingerprints
expected: {:global {:distinct-count 100, :nil% 0.0},
:type {:type/Text {:average-length #<Fn@2ee5402f metabase.sync.analyze.fingerprint_test/fn__139755[fn/fn]>,
:percent-email 0.0,
:percent-json 0.0,
:percent-state 0.0,
:percent-url 0.0}}}
actual: nil
```
* Typo fix
---
src/metabase/driver/ddl/interface.clj | 2 +-
test/metabase/sync/analyze/fingerprint_test.clj | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/metabase/driver/ddl/interface.clj b/src/metabase/driver/ddl/interface.clj
index f56a6457f21..662c2ca4f77 100644
--- a/src/metabase/driver/ddl/interface.clj
+++ b/src/metabase/driver/ddl/interface.clj
@@ -15,7 +15,7 @@
(mu/defn schema-name :- ::lib.schema.common/non-blank-string
"Returns a schema name for persisting models. Needs the database to use the db id and the site-uuid to ensure that
- multiple connections from multiple metabae remain distinct. The UUID will have the first character of each section taken.
+ multiple connections from multiple metabases remain distinct. The UUID will have the first character of each section taken.
(schema-name {:id 234} \"143dd8ce-e116-4c7f-8d6d-32e99eaefbbc\") -> \"metabase_cache_1e483_1\""
[{:keys [id] :as _database} :- [:map [:id ::lib.schema.id/database]]
diff --git a/test/metabase/sync/analyze/fingerprint_test.clj b/test/metabase/sync/analyze/fingerprint_test.clj
index 8675f1af09d..f7a4cf808bf 100644
--- a/test/metabase/sync/analyze/fingerprint_test.clj
+++ b/test/metabase/sync/analyze/fingerprint_test.clj
@@ -280,10 +280,11 @@
(is (= (fingerprint/empty-stats-map 0)
(fingerprint/fingerprint-fields-for-db! fake-db [(t2/select-one Table :id (data/id :venues))] (fn [_ _]))))))))
-(deftest ^:parallel fingerprint-test
+(deftest fingerprint-test
(mt/test-drivers (mt/normal-drivers)
(testing "Fingerprints should actually get saved with the correct values"
(testing "Text fingerprints"
+ (fingerprint/fingerprint-fields! (t2/select-one Table :id (data/id :venues)))
(is (=? {:global {:distinct-count 100
:nil% 0.0}
:type {:type/Text {:percent-json 0.0
--
GitLab