diff --git a/frontend/src/metabase-lib/lib/parameters/utils/click-behavior.js b/frontend/src/metabase-lib/lib/parameters/utils/click-behavior.js index 0a1a815ea83d5dc26cdf5dcf8868c873df758e5a..596131d2f7bef8d27be6e3e53b576dade07bde08 100644 --- a/frontend/src/metabase-lib/lib/parameters/utils/click-behavior.js +++ b/frontend/src/metabase-lib/lib/parameters/utils/click-behavior.js @@ -3,7 +3,6 @@ import { getIn } from "icepick"; import { parseTimestamp } from "metabase/lib/time"; import { formatDateTimeForParameter } from "metabase/lib/formatting/date"; -import { isValidImplicitActionClickBehavior } from "metabase/writeback/utils"; import { dimensionFilterForParameter, variableFilterForParameter, @@ -231,6 +230,26 @@ export function clickBehaviorIsValid(clickBehavior) { return false; } +function isValidImplicitActionClickBehavior(clickBehavior) { + if ( + !clickBehavior || + clickBehavior.type !== "action" || + !("actionType" in clickBehavior) + ) { + return false; + } + if (clickBehavior.actionType === "insert") { + return clickBehavior.tableId != null; + } + if ( + clickBehavior.actionType === "update" || + clickBehavior.actionType === "delete" + ) { + return typeof clickBehavior.objectDetailDashCardId === "number"; + } + return false; +} + export function formatSourceForTarget( source, target, diff --git a/frontend/src/metabase/writeback/utils.ts b/frontend/src/metabase/writeback/utils.ts index 6a067db4e011bee3a5ea95ccae6bce2237785480..b8daf5b8051b5c73d339fa54a32cfbc76eca15c0 100644 --- a/frontend/src/metabase/writeback/utils.ts +++ b/frontend/src/metabase/writeback/utils.ts @@ -87,28 +87,6 @@ export function isMappedExplicitActionButton( ); } -export function isValidImplicitActionClickBehavior( - clickBehavior?: ClickBehavior, -) { - if ( - !clickBehavior || - clickBehavior.type !== "action" || - !("actionType" in clickBehavior) - ) { - return false; - } - if (clickBehavior.actionType === "insert") { - return clickBehavior.tableId != null; - } - if ( - clickBehavior.actionType === "update" || - clickBehavior.actionType === "delete" - ) { - return typeof clickBehavior.objectDetailDashCardId === "number"; - } - return false; -} - export function getActionButtonLabel(dashCard: ActionDashboardCard) { const label = dashCard.visualization_settings?.["button.label"]; return label || "";