From 486e3370af429176649ffa00b3c3accf3de81ef8 Mon Sep 17 00:00:00 2001
From: Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
Date: Thu, 6 Jun 2024 17:54:35 -0400
Subject: [PATCH] hide "show_series_values" setting when "show_values" setting
is disabled (#43785)
---
frontend/src/metabase/visualizations/lib/settings/series.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/frontend/src/metabase/visualizations/lib/settings/series.js b/frontend/src/metabase/visualizations/lib/settings/series.js
index d532a2f84ee..c28f0da8c48 100644
--- a/frontend/src/metabase/visualizations/lib/settings/series.js
+++ b/frontend/src/metabase/visualizations/lib/settings/series.js
@@ -184,7 +184,7 @@ export function seriesSetting({
inline: true,
getHidden: (single, seriesSettings, { settings, series }) =>
series.length <= 1 || // no need to show series-level control if there's only one series
- !Object.prototype.hasOwnProperty.call(settings, "graph.show_values") || // don't show it unless this chart has a global setting
+ !settings["graph.show_values"] || // don't show it unless this chart has a global setting
settings["stackable.stack_type"], // hide series controls if the chart is stacked
getDefault: (single, seriesSettings, { settings }) =>
getSeriesDefaultShowSeriesValues(settings),
--
GitLab