From 4aa5df0821bd208fc8114d48795fdfd36ffe101c Mon Sep 17 00:00:00 2001
From: Anton Kulyk <kuliks.anton@gmail.com>
Date: Mon, 20 Feb 2023 13:11:14 +0000
Subject: [PATCH] Add missing `nock.cleanAll` calls (#28441)
---
.../components/ActionViz/ActionDashcardSettings.unit.spec.tsx | 4 ++++
.../nav/containers/MainNavbar/MainNavbar.unit.spec.tsx | 4 ++++
frontend/src/metabase/nav/containers/Navbar.unit.spec.tsx | 4 ++++
.../test/metabase/admin/tasks/containers/Logs.unit.spec.js | 4 ++++
4 files changed, 16 insertions(+)
diff --git a/frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.unit.spec.tsx b/frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.unit.spec.tsx
index 10d7021cda5..8297773d62f 100644
--- a/frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.unit.spec.tsx
+++ b/frontend/src/metabase/actions/components/ActionViz/ActionDashcardSettings.unit.spec.tsx
@@ -110,6 +110,10 @@ const setup = (
};
describe("ActionViz > ActionDashcardSettings", () => {
+ afterEach(() => {
+ nock.cleanAll();
+ });
+
it("shows the action dashcard settings component", () => {
setup();
diff --git a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbar.unit.spec.tsx b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbar.unit.spec.tsx
index b0dae568fe3..ea11ca49de2 100644
--- a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbar.unit.spec.tsx
+++ b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbar.unit.spec.tsx
@@ -166,6 +166,10 @@ async function setupCollectionPage({
}
describe("nav > containers > MainNavbar", () => {
+ afterEach(() => {
+ nock.cleanAll();
+ });
+
describe("homepage link", () => {
it("should render", async () => {
await setup();
diff --git a/frontend/src/metabase/nav/containers/Navbar.unit.spec.tsx b/frontend/src/metabase/nav/containers/Navbar.unit.spec.tsx
index 4d8b2b4b175..34e81827099 100644
--- a/frontend/src/metabase/nav/containers/Navbar.unit.spec.tsx
+++ b/frontend/src/metabase/nav/containers/Navbar.unit.spec.tsx
@@ -65,6 +65,10 @@ async function setup({
}
describe("nav > containers > Navbar > Core App", () => {
+ afterEach(() => {
+ nock.cleanAll();
+ });
+
it("should be open when isOpen is true", async () => {
await setup({ isOpen: true });
const navbar = screen.getByTestId("main-navbar-root");
diff --git a/frontend/test/metabase/admin/tasks/containers/Logs.unit.spec.js b/frontend/test/metabase/admin/tasks/containers/Logs.unit.spec.js
index 7c08382bf91..9a1cfd70005 100644
--- a/frontend/test/metabase/admin/tasks/containers/Logs.unit.spec.js
+++ b/frontend/test/metabase/admin/tasks/containers/Logs.unit.spec.js
@@ -6,6 +6,10 @@ import Logs from "metabase/admin/tasks/containers/Logs";
import { UtilApi } from "metabase/services";
describe("Logs", () => {
+ afterEach(() => {
+ nock.cleanAll();
+ });
+
describe("log fetching", () => {
afterEach(() => nock.cleanAll());
--
GitLab