From 4ab6c6eb42284ea3b4538debef2774ae59c72c1b Mon Sep 17 00:00:00 2001
From: Ryan Laurie <30528226+iethree@users.noreply.github.com>
Date: Mon, 18 Nov 2024 10:19:56 -0700
Subject: [PATCH] Update slack settings urls (#50042)
---
.../app/components/DeprecationNotice/DeprecationNotice.tsx | 2 +-
src/metabase/api/setup.clj | 2 +-
src/metabase/email/slack_token_error.hbs | 2 +-
test/metabase/notification/payload/impl/system_event_test.clj | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/frontend/src/metabase/admin/app/components/DeprecationNotice/DeprecationNotice.tsx b/frontend/src/metabase/admin/app/components/DeprecationNotice/DeprecationNotice.tsx
index a8d039da32f..9c1f252897f 100644
--- a/frontend/src/metabase/admin/app/components/DeprecationNotice/DeprecationNotice.tsx
+++ b/frontend/src/metabase/admin/app/components/DeprecationNotice/DeprecationNotice.tsx
@@ -42,7 +42,7 @@ const getBannerContent = (
hasDeprecatedDatabase: boolean,
) => {
const databaseListUrl = "/admin/databases";
- const slackSettingsUrl = "/admin/settings/slack";
+ const slackSettingsUrl = "/admin/settings/notifications/slack";
if (hasSlackBot && hasDeprecatedDatabase) {
return jt`You’re using a ${(
diff --git a/src/metabase/api/setup.clj b/src/metabase/api/setup.clj
index 85107bb118e..421f005aab7 100644
--- a/src/metabase/api/setup.clj
+++ b/src/metabase/api/setup.clj
@@ -221,7 +221,7 @@
{:title (tru "Set Slack credentials")
:group (tru "Get connected")
:description (tru "Does your team use Slack? If so, you can send automated updates via dashboard subscriptions.")
- :link "/admin/settings/slack"
+ :link "/admin/settings/notifications/slack"
:completed (configured :slack)
:triggered :always}
{:title (tru "Setup embedding")
diff --git a/src/metabase/email/slack_token_error.hbs b/src/metabase/email/slack_token_error.hbs
index 6d2f3e5ec54..35d0fd76244 100644
--- a/src/metabase/email/slack_token_error.hbs
+++ b/src/metabase/email/slack_token_error.hbs
@@ -7,6 +7,6 @@
<h2 style="font-weight: normal; color: #4C545B; line-height: 34px;">Your Slack connection stopped working</h2>
<p style="line-height: 22px; margin-bottom: 40px">This may affect existing dashboard subscriptions. Follow the steps in settings to reconnect Slack and get things up and running again.</p>
</div>
- <a style="{{context.style.button}}" href="{{context.site_url}}/admin/settings/slack">Go to settings</a>
+ <a style="{{context.style.button}}" href="{{context.site_url}}/admin/settings/notifications/slack">Go to settings</a>
</div>
{{> metabase/email/_footer.hbs }}
diff --git a/test/metabase/notification/payload/impl/system_event_test.clj b/test/metabase/notification/payload/impl/system_event_test.clj
index 8eee167ba49..d2d7f539f2c 100644
--- a/test/metabase/notification/payload/impl/system_event_test.clj
+++ b/test/metabase/notification/payload/impl/system_event_test.clj
@@ -201,7 +201,7 @@
admin-emails (t2/select-fn-set :email :model/User :is_superuser true)]
(testing "send to admins with a link to setting page"
(check admin-emails [#"Your Slack connection stopped working"
- #"<a[^>]*href=\"https?://metabase\.com/admin/settings/slack\"[^>]*>Go to settings</a>"]))
+ #"<a[^>]*href=\"https?://metabase\.com/admin/settings/notifications/slack\"[^>]*>Go to settings</a>"]))
(mt/with-temporary-setting-values
[admin-email "it@metabase.com"]
--
GitLab