From 4f078bc38902f5b83d6ad9c19a43ac0d204c678b Mon Sep 17 00:00:00 2001
From: Ariya Hidayat <ariya@metabase.com>
Date: Mon, 3 Jan 2022 16:42:49 -0800
Subject: [PATCH] Custom expression editor: hide error on the correction
attempt (#19516)
---
.../components/expressions/ExpressionEditorTextfield.jsx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx b/frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx
index 7b0e60e78c7..181578a36e4 100644
--- a/frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx
+++ b/frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx
@@ -307,7 +307,7 @@ export default class ExpressionEditorTextfield extends React.Component {
};
handleExpressionChange(source) {
- this.setState({ source });
+ this.setState({ source, errorMessage: null });
if (this.props.onBlankChange) {
this.props.onBlankChange(source.length === 0);
}
@@ -400,7 +400,7 @@ export default class ExpressionEditorTextfield extends React.Component {
highlightedIndex={this.state.highlightedSuggestionIndex}
/>
</EditorContainer>
- <ErrorMessage error={errorMessage} />
+ {!isFocused && <ErrorMessage error={errorMessage} />}
<HelpText helpText={this.state.helpText} width={this.props.width} />
</React.Fragment>
);
--
GitLab