diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index dd25ed9d5f12f60871d0844fb26685c0d07a8f5c..58688e53d0a6d6787bce835df1738bc5963720e2 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -144,7 +144,7 @@ jobs: run: | yarn run test-cypress-run \ --env grepTags=@OSS,grepOmitFiltered=true \ - --spec './e2e/test/scenarios/**/*.cy.spec.js' \ + --spec './e2e/test/scenarios/**/*.cy.spec.(js|ts)' \ --browser 'replay-chromium' - name: Run slow and resource-intensive Cypress tests @@ -152,7 +152,7 @@ jobs: run: | yarn run test-cypress-run \ --env grepTags="@slow",grepOmitFiltered=true \ - --spec './e2e/test/scenarios/**/*.cy.spec.js' \ + --spec './e2e/test/scenarios/**/*.cy.spec.(js|ts)' \ --browser 'replay-chromium' - name: Run Flaky Cypress tests @@ -160,7 +160,7 @@ jobs: run: | yarn run test-cypress-run \ --env grepTags="@flaky --@quarantine",grepOmitFiltered=true \ - --spec './e2e/test/scenarios/**/*.cy.spec.js' \ + --spec './e2e/test/scenarios/**/*.cy.spec.(js|ts)' \ --browser 'replay-chromium' - name: Run EE Cypress tests on ${{ matrix.name }} @@ -176,7 +176,7 @@ jobs: run: | yarn run test-cypress-run \ --env grepTags="@mongo --@quarantine",grepOmitFiltered=true \ - --spec './e2e/test/scenarios/**/*.cy.spec.js' \ + --spec './e2e/test/scenarios/**/*.cy.spec.(js|ts)' \ --browser 'replay-chromium' env: CYPRESS_QA_DB_MONGO: true diff --git a/e2e/test/scenarios/question/notebook-data-source.cy.spec.ts b/e2e/test/scenarios/question/notebook-data-source.cy.spec.ts index 320730dff97e30f78e8c53fdb80a32b28d8333d1..0c35c2e044d4fb2a53f17c2ebe314b731f9c69b1 100644 --- a/e2e/test/scenarios/question/notebook-data-source.cy.spec.ts +++ b/e2e/test/scenarios/question/notebook-data-source.cy.spec.ts @@ -418,7 +418,7 @@ describe("scenarios > notebook > data source", () => { }); }); -describeOSS("scenarios > notebook > data source", () => { +describeOSS("scenarios > notebook > data source", { tags: "@OSS" }, () => { beforeEach(() => { restore("setup"); cy.signInAsAdmin(); @@ -433,19 +433,12 @@ describeOSS("scenarios > notebook > data source", () => { }); startNewQuestion(); - popover().within(() => { - cy.findByPlaceholderText("Search for some data…"); - cy.findAllByTestId("data-bucket-list-item") - .as("sources") - .should("have.length", 2); - cy.get("@sources") - .first() - .should("contain", "Models") - .and("have.attr", "aria-selected", "false"); - cy.get("@sources") - .last() - .should("contain", "Raw Data") - .and("have.attr", "aria-selected", "false"); + entityPickerModal().within(() => { + cy.findAllByRole("tab").should("have.length", 2); + entityPickerModalTab("Recents").should("not.exist"); + entityPickerModalTab("Models").and("have.attr", "aria-selected", "true"); + entityPickerModalTab("Tables").should("exist"); + entityPickerModalTab("Saved questions").should("not.exist"); }); }); }); diff --git a/e2e/test/scenarios/question/notebook-native-preview-sidebar.cy.spec.ts b/e2e/test/scenarios/question/notebook-native-preview-sidebar.cy.spec.ts index 0e186b8b41617dc1873c48068353a84a75cd6d07..4e91ddeb45365f6a45e5982421640aefff59e9b4 100644 --- a/e2e/test/scenarios/question/notebook-native-preview-sidebar.cy.spec.ts +++ b/e2e/test/scenarios/question/notebook-native-preview-sidebar.cy.spec.ts @@ -26,6 +26,7 @@ import { expectGoodSnowplowEvents, expectNoBadSnowplowEvents, entityPickerModal, + entityPickerModalTab, } from "e2e/support/helpers"; const { ORDERS, ORDERS_ID } = SAMPLE_DATABASE; @@ -281,8 +282,8 @@ describe( it("should work for both simple and nested questions based on previously converted GUI query", () => { startNewQuestion(); - popover().within(() => { - cy.findByText("Raw Data").click(); + entityPickerModal().within(() => { + entityPickerModalTab("Tables").click(); cy.findByText(MONGO_DB_NAME).click(); cy.findByText("Products").click(); });