From 4fb0c32bd6fda4c23828e7d433b1e462ecf273c2 Mon Sep 17 00:00:00 2001
From: Simon Belak <simon@metabase.com>
Date: Sat, 27 Oct 2018 11:21:02 +0200
Subject: [PATCH] Instantiate all localized strings before saving a dashboard
[ci all]
---
src/metabase/models/dashboard.clj | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/metabase/models/dashboard.clj b/src/metabase/models/dashboard.clj
index f9a71ab8715..39937027bbd 100644
--- a/src/metabase/models/dashboard.clj
+++ b/src/metabase/models/dashboard.clj
@@ -21,6 +21,7 @@
[revision :as revision]]
[metabase.models.revision.diff :refer [build-sentence]]
[metabase.query-processor.interface :as qpi]
+ [metabase.util.i18n :as ui18n]
[toucan
[db :as db]
[hydrate :refer [hydrate]]
@@ -256,9 +257,10 @@
(defn save-transient-dashboard!
"Save a denormalized description of `dashboard`."
[dashboard parent-collection-id]
- (let [dashcards (:ordered_cards dashboard)
+ (let [dashboard (ui18n/localized-strings->strings dashboard)
+ dashcards (:ordered_cards dashboard)
collection (magic.populate/create-collection!
- (ensure-unique-collection-name (str (:name dashboard)) parent-collection-id)
+ (ensure-unique-collection-name (:name dashboard) parent-collection-id)
(rand-nth magic.populate/colors)
"Automatically generated cards."
parent-collection-id)
--
GitLab