From 524b610fa99a4a7d259fb461dfcb46a8302891c7 Mon Sep 17 00:00:00 2001
From: github-automation-metabase
<166700802+github-automation-metabase@users.noreply.github.com>
Date: Fri, 15 Nov 2024 07:24:28 -0500
Subject: [PATCH] enforce key prop on tooltip row in echarts tooltip (#50045)
(#50073)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Co-authored-by: Nicolò Pretto <info@npretto.com>
---
.../ChartTooltip/EChartsTooltip/EChartsTooltip.tsx | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/frontend/src/metabase/visualizations/components/ChartTooltip/EChartsTooltip/EChartsTooltip.tsx b/frontend/src/metabase/visualizations/components/ChartTooltip/EChartsTooltip/EChartsTooltip.tsx
index a6ba65c316c..b1c837a2199 100644
--- a/frontend/src/metabase/visualizations/components/ChartTooltip/EChartsTooltip/EChartsTooltip.tsx
+++ b/frontend/src/metabase/visualizations/components/ChartTooltip/EChartsTooltip/EChartsTooltip.tsx
@@ -67,11 +67,12 @@ export const EChartsTooltip = ({
})}
>
<tbody>
- {paddedRows.map(row => {
+ {paddedRows.map((row, i) => {
+ const key = row.key ?? String(i);
return !row.isSecondary ? (
- <TooltipRow {...row} />
+ <TooltipRow {...row} key={key} />
) : (
- <SecondaryRow {...row} />
+ <SecondaryRow {...row} key={key} />
);
})}
</tbody>
--
GitLab