From 52e2895ac633ea381db3f2da9ff420baa4bb93bc Mon Sep 17 00:00:00 2001 From: Nick Fitzpatrick <nick@metabase.com> Date: Wed, 10 Aug 2022 12:28:07 -0300 Subject: [PATCH] fixing button variant mapping for dashcard parameter filters (#24688) --- .../components/DashCardCardParameterMapper.jsx | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/frontend/src/metabase/dashboard/components/DashCardCardParameterMapper.jsx b/frontend/src/metabase/dashboard/components/DashCardCardParameterMapper.jsx index 32085c06d0a..4a6f7b76dba 100644 --- a/frontend/src/metabase/dashboard/components/DashCardCardParameterMapper.jsx +++ b/frontend/src/metabase/dashboard/components/DashCardCardParameterMapper.jsx @@ -112,22 +112,22 @@ function DashCardCardParameterMapper({ useMemo(() => { if (!hasPermissionsToMap) { return { - variant: "unauthed", - tooltip: t`You don’t have permission to see this question’s columns.`, - text: null, + buttonVariant: "unauthed", + buttonTooltip: t`You don’t have permission to see this question’s columns.`, + buttonText: null, buttonIcon: <KeyIcon />, }; } else if (isDisabled && !isVirtual) { return { - variant: "disabled", - tooltip: t`This card doesn't have any fields or parameters that can be mapped to this parameter type.`, + buttonVariant: "disabled", + buttonTooltip: t`This card doesn't have any fields or parameters that can be mapped to this parameter type.`, buttonText: t`No valid fields`, buttonIcon: null, }; } else if (selectedMappingOption) { return { - variant: "mapped", - tooltip: null, + buttonVariant: "mapped", + buttonTooltip: null, buttonText: formatSelected(selectedMappingOption), buttonIcon: ( <CloseIconButton @@ -140,8 +140,8 @@ function DashCardCardParameterMapper({ }; } else { return { - variant: "default", - tooltip: null, + buttonVariant: "default", + buttonTooltip: null, buttonText: t`Select…`, buttonIcon: <ChevrondownIcon />, }; -- GitLab