From 566a2688e3072336edd984cc911ed49f8370c692 Mon Sep 17 00:00:00 2001
From: Maz Ameli <maz@metabase.com>
Date: Tue, 13 Sep 2022 23:43:22 -0700
Subject: [PATCH] update strings in tests (#25409)
---
.../embedding/embedding-smoketests.cy.spec.js | 12 ++++--------
.../scenarios/visualizations/pivot_tables.cy.spec.js | 8 ++------
2 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/frontend/test/metabase/scenarios/embedding/embedding-smoketests.cy.spec.js b/frontend/test/metabase/scenarios/embedding/embedding-smoketests.cy.spec.js
index 449f38e8b29..4897973a5b8 100644
--- a/frontend/test/metabase/scenarios/embedding/embedding-smoketests.cy.spec.js
+++ b/frontend/test/metabase/scenarios/embedding/embedding-smoketests.cy.spec.js
@@ -240,30 +240,26 @@ function assertLinkMatchesUrl(text, url) {
function ensureEmbeddingIsDisabled() {
// This is implicit assertion - it would've failed if embedding was enabled
- cy.findByText(/Embed this (question|dashboard) in an application/).closest(
- ".disabled",
- );
+ cy.findByText(/Embed in your application/).closest(".disabled");
// Let's make sure embedding stays disabled after we enable public sharing
enableSharing();
- cy.findByText(/Embed this (question|dashboard) in an application/).closest(
- ".disabled",
- );
+ cy.findByText(/Embed in your application/).closest(".disabled");
}
function visitAndEnableSharing(object) {
if (object === "question") {
visitQuestion("1");
cy.icon("share").click();
- cy.findByText(/Embed this (question|dashboard) in an application/).click();
+ cy.findByText(/Embed in your application/).click();
}
if (object === "dashboard") {
visitDashboard(1);
cy.icon("share").click();
- cy.findByText(/Embed this (question|dashboard) in an application/).click();
+ cy.findByText(/Embed in your application/).click();
}
}
diff --git a/frontend/test/metabase/scenarios/visualizations/pivot_tables.cy.spec.js b/frontend/test/metabase/scenarios/visualizations/pivot_tables.cy.spec.js
index 38b6e0d6f05..ace34211dcb 100644
--- a/frontend/test/metabase/scenarios/visualizations/pivot_tables.cy.spec.js
+++ b/frontend/test/metabase/scenarios/visualizations/pivot_tables.cy.spec.js
@@ -619,18 +619,14 @@ describe("scenarios > visualizations > pivot tables", () => {
// Skipped to avoid flake
it.skip("should display pivot table in an embed preview", () => {
- cy.findByText(
- /Embed this (question|dashboard) in an application/,
- ).click();
+ cy.findByText(/Embed in your application/).click();
// we use preview endpoints when MB is iframed in itself
cy.findByText(test.subject);
getIframeBody().within(assertOnPivotFields);
});
it("should display pivot table in an embed URL", () => {
- cy.findByText(
- /Embed this (question|dashboard) in an application/,
- ).click();
+ cy.findByText(/Embed in your application/).click();
cy.findByText("Publish").click();
--
GitLab