From 56ed43e19c46ef317aff401816a6d21c26b72b6a Mon Sep 17 00:00:00 2001
From: Alexander Polyankin <alexander.polyankin@metabase.com>
Date: Fri, 8 Jul 2022 15:19:23 +0300
Subject: [PATCH] Show caching controls only for questions (#23784)
---
.../components/view/sidebars/QuestionInfoSidebar.tsx | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar.tsx
index d45706a53a7..28ee9c5ce65 100644
--- a/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar.tsx
+++ b/frontend/src/metabase/query_builder/components/view/sidebars/QuestionInfoSidebar.tsx
@@ -27,9 +27,10 @@ export const QuestionInfoSidebar = ({
const description = question.description();
const isDataset = question.isDataset();
const isPersisted = isDataset && question.isPersisted();
-
- const showCaching =
- PLUGIN_CACHING.isEnabled() && MetabaseSettings.get("enable-query-caching");
+ const isCachingAvailable =
+ !isDataset &&
+ PLUGIN_CACHING.isEnabled() &&
+ MetabaseSettings.get("enable-query-caching");
const handleSave = (description: string | null) => {
if (question.description() !== description) {
@@ -63,7 +64,7 @@ export const QuestionInfoSidebar = ({
</ContentSection>
)}
- {showCaching && (
+ {isCachingAvailable && (
<ContentSection extraPadding>
<PLUGIN_CACHING.QuestionCacheSection
question={question}
--
GitLab