From 5c870bdaae58ca8051baa639ec97cea623104a3a Mon Sep 17 00:00:00 2001
From: Cam Saul <1455846+camsaul@users.noreply.github.com>
Date: Wed, 5 Feb 2020 10:31:41 -0800
Subject: [PATCH] Add note about bumping version.properties [ci skip]
---
docs/developers-guide-osx.md | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/docs/developers-guide-osx.md b/docs/developers-guide-osx.md
index 0596e9e57cc..0889fa63415 100644
--- a/docs/developers-guide-osx.md
+++ b/docs/developers-guide-osx.md
@@ -107,6 +107,10 @@ After following the configuration steps above, to build and release the app you
cp path/to/metabase.jar OSX/Resources/metabase.jar
```
+1. Bump version number (`tag`) in `./bin/version.properties` unless uberjar was built locally
+
+ The build script reads this file, which is generated by `./bin/build`; it assumes the uberjar was built locally, which is a bad assumption. This is something we should fix
+
1. Bundle entire app, and upload to s3
```bash
--
GitLab