From 5d3e7c76d1ea8483ffd76e42fe195e3042da89da Mon Sep 17 00:00:00 2001
From: Nick Fitzpatrick <nick@metabase.com>
Date: Wed, 6 Jul 2022 12:47:52 -0300
Subject: [PATCH] Adding Tooltip to Entity Action Menu (#23733)
---
.../components/CollectionHeader/CollectionMenu.tsx | 8 +++++++-
.../src/metabase/dashboard/containers/DashboardHeader.jsx | 6 +++++-
.../metabase/query_builder/components/QuestionActions.tsx | 6 +++++-
3 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/frontend/src/metabase/collections/components/CollectionHeader/CollectionMenu.tsx b/frontend/src/metabase/collections/components/CollectionHeader/CollectionMenu.tsx
index 389f6fb91a3..cf09be1aa7f 100644
--- a/frontend/src/metabase/collections/components/CollectionHeader/CollectionMenu.tsx
+++ b/frontend/src/metabase/collections/components/CollectionHeader/CollectionMenu.tsx
@@ -65,7 +65,13 @@ const CollectionMenu = ({
}
if (items.length > 0) {
- return <EntityMenu items={items} triggerIcon="ellipsis" />;
+ return (
+ <EntityMenu
+ items={items}
+ triggerIcon="ellipsis"
+ tooltip={t`Move, archive, and more...`}
+ />
+ );
} else {
return null;
}
diff --git a/frontend/src/metabase/dashboard/containers/DashboardHeader.jsx b/frontend/src/metabase/dashboard/containers/DashboardHeader.jsx
index d7a1211fc10..82af444854c 100644
--- a/frontend/src/metabase/dashboard/containers/DashboardHeader.jsx
+++ b/frontend/src/metabase/dashboard/containers/DashboardHeader.jsx
@@ -354,7 +354,11 @@ class DashboardHeader extends Component {
: setSidebar({ name: SIDEBAR_NAME.info })
}
/>
- <EntityMenu items={extraButtons} triggerIcon="ellipsis" />
+ <EntityMenu
+ items={extraButtons}
+ triggerIcon="ellipsis"
+ tooltip={t`Move, archive, and more...`}
+ />
</DashboardHeaderActionContainer>,
);
}
diff --git a/frontend/src/metabase/query_builder/components/QuestionActions.tsx b/frontend/src/metabase/query_builder/components/QuestionActions.tsx
index 541a4c9b4d4..bc9f4e4d5c4 100644
--- a/frontend/src/metabase/query_builder/components/QuestionActions.tsx
+++ b/frontend/src/metabase/query_builder/components/QuestionActions.tsx
@@ -221,7 +221,11 @@ const QuestionActions = ({
color={infoButtonColor}
/>
</Tooltip>
- <EntityMenu items={extraButtons} triggerIcon="ellipsis" />
+ <EntityMenu
+ items={extraButtons}
+ triggerIcon="ellipsis"
+ tooltip={t`Move, archive, and more...`}
+ />
</QuestionActionsContainer>
);
};
--
GitLab