From 5e7067110843870f7b465f108c87cbd6f08be2d6 Mon Sep 17 00:00:00 2001 From: dpsutton <dan@dpsutton.com> Date: Fri, 16 Aug 2024 17:47:39 -0500 Subject: [PATCH] Include missing opts arg for transform->nested (#46944) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit was missing from the call. Also had to disable hooks to commit: ``` ✖ clj-kondo --config ./.clj-kondo/config.edn --config-dir ./.clj-kondo --parallel --lint: metabase/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj:458:20: warning: Unresolved var: ts/extract-one metabase/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj:1691:8: warning: Unresolved var: mbc/ensure-audit-db-installed! metabase/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj:1757:18: warning: Unresolved var: ts/create! linting took 247ms, errors: 0, warnings: 3 error Command failed with exit code 1. ``` --- .../metabase_enterprise/serialization/v2/extract_test.clj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj b/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj index a975cc8a177..3b4e3924256 100644 --- a/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj +++ b/enterprise/backend/test/metabase_enterprise/serialization/v2/extract_test.clj @@ -1717,12 +1717,12 @@ :model/DashboardCardSeries s {:dashboardcard_id (:id dc1) :card_id (:id c2)}] (let [spec (serdes/make-spec "DashboardCard" nil)] (is (= {(:id dc1) [s]} - (#'serdes/transform->nested (-> spec :transform :series) [dc1]))) + (#'serdes/transform->nested (-> spec :transform :series) {} [dc1]))) (is (=? (assoc dc1 :series [s]) (u/rfirst (serdes/extract-query "DashboardCard" {:where [:= :id (:id dc1)]}))))) (let [spec (serdes/make-spec "Dashboard" nil)] (is (= {(:id d) [(assoc dc1 :series [s])]} - (#'serdes/transform->nested (-> spec :transform :dashcards) [d]))) + (#'serdes/transform->nested (-> spec :transform :dashcards) {} [d]))) (is (=? (assoc d :dashcards [(assoc dc1 :series [s])] :tabs nil) -- GitLab