From 5f349ea696ad394c4c5d2fbb41fa26a8a03b14c8 Mon Sep 17 00:00:00 2001
From: Braden Shepherdson <braden@metabase.com>
Date: Thu, 18 May 2023 14:43:40 -0400
Subject: [PATCH] Unskip repro for #30743; it was fixed by #30755 (#30850)
Just removing the unnecessary setting of `display: table` since the test
expects the default bars.
Fixes #30743.
---
.../30743-sort-on-breakout-column-crashes.cy.spec.js | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/e2e/test/scenarios/joins/reproductions/30743-sort-on-breakout-column-crashes.cy.spec.js b/e2e/test/scenarios/joins/reproductions/30743-sort-on-breakout-column-crashes.cy.spec.js
index 4d9e45bb6cc..fb43370e7ad 100644
--- a/e2e/test/scenarios/joins/reproductions/30743-sort-on-breakout-column-crashes.cy.spec.js
+++ b/e2e/test/scenarios/joins/reproductions/30743-sort-on-breakout-column-crashes.cy.spec.js
@@ -10,7 +10,6 @@ import { SAMPLE_DB_ID } from "e2e/support/cypress_data";
const { ORDERS, ORDERS_ID, PRODUCTS, PRODUCTS_ID } = SAMPLE_DATABASE;
const query = {
- display: "table",
dataset_query: {
database: SAMPLE_DB_ID,
type: "query",
@@ -34,7 +33,7 @@ const query = {
},
};
-describe.skip("issue 20743", () => {
+describe("issue 30743", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
@@ -42,7 +41,7 @@ describe.skip("issue 20743", () => {
visitQuestionAdhoc(query, { mode: "notebook" });
});
- it("should be possible to sort on the breakout column (metabase#20743)", () => {
+ it("should be possible to sort on the breakout column (metabase#30743)", () => {
cy.findByLabelText("Sort").click();
popover().contains("Category").click();
--
GitLab