From 5fcf4a3aa216298ec12a2d380668df0ab33d9e16 Mon Sep 17 00:00:00 2001
From: Ngoc Khuat <qn.khuat@gmail.com>
Date: Tue, 2 Nov 2021 00:33:42 +0700
Subject: [PATCH] fix failed to start front-end development due to missing
version.properties file (#18523)
---
frontend/src/metabase/lib/settings.ts | 2 +-
frontend/test/metabase/lib/settings.unit.spec.js | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/frontend/src/metabase/lib/settings.ts b/frontend/src/metabase/lib/settings.ts
index 3aaaf3df704..f6bd0c3c12f 100644
--- a/frontend/src/metabase/lib/settings.ts
+++ b/frontend/src/metabase/lib/settings.ts
@@ -191,7 +191,7 @@ class Settings {
docsUrl(page = "", anchor = "") {
let { tag } = this.get("version", {});
- const matches = tag.match(/v[01]\.(\d+)(?:\.\d+)?(-.*)?/);
+ const matches = tag && tag.match(/v[01]\.(\d+)(?:\.\d+)?(-.*)?/);
if (matches) {
if (
diff --git a/frontend/test/metabase/lib/settings.unit.spec.js b/frontend/test/metabase/lib/settings.unit.spec.js
index bd155bd803e..0967a00c170 100644
--- a/frontend/test/metabase/lib/settings.unit.spec.js
+++ b/frontend/test/metabase/lib/settings.unit.spec.js
@@ -14,6 +14,7 @@ describe("MetabaseSettings.docsUrl", () => {
// all of these should point to the same doc URL
[
["v0.41.0", "v0.41"],
+ [undefined, "latest"],
["v0.41.1-SNAPSHOT", "latest"],
["v0.41.2-rc1", "v0.41"],
["v0.41.3-RC2", "v0.41"],
--
GitLab