diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/components/AuditSidebar.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/components/AuditSidebar.jsx index c5169e8b50c151949697450685bb8666a1c005bb..cbd34363e24da13559a45b822da1fad8d2668760 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/components/AuditSidebar.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/components/AuditSidebar.jsx @@ -6,12 +6,6 @@ import { IndexLink } from "react-router"; import Link from "metabase/components/Link"; import cx from "classnames"; -type Props = { - className?: string, - style?: { [key: string]: any }, - children?: React.Element, -}; - const AuditSidebarSection = ({ title, children }) => ( <div className="pb2"> {title && <AuditSidebarSectionTitle title={title} />} @@ -47,13 +41,13 @@ const AuditSidebarItem = ({ title, path }) => ( </div> ); -const AuditSidebar = ({ className, style, children }: Props) => ( +const AuditSidebar = ({ className, style, children }) => ( <div style={style} className={cx("p4", className)}> {children} </div> ); -const AuditAppSidebar = (props: Props) => ( +const AuditAppSidebar = props => ( <AuditSidebar {...props}> <AuditSidebarSection title={t`People`}> <AuditSidebarItem title={t`Team members`} path="/admin/audit/members" /> diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/components/OpenInMetabase.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/components/OpenInMetabase.jsx index 5d5128c3eca7151b7253da43066eceba8c44ac27..10d8ac8997c632d0067a637b67b4f1f4c01aaeea 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/components/OpenInMetabase.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/components/OpenInMetabase.jsx @@ -1,13 +1,10 @@ +/* eslint-disable react/prop-types */ import React from "react"; import Link from "metabase/components/Link"; import Icon from "metabase/components/Icon"; -type Props = { - to: string, -}; - -const OpenInMetabase = ({ ...props }: Props) => ( +const OpenInMetabase = ({ ...props }) => ( <Link {...props} className="link flex align-center" target="_blank"> <Icon name="external" className="mr1" /> Open in Metabase diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/containers/AuditApp.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/containers/AuditApp.jsx index 6e70ffcc9cf786095eaafefdad2636d94a73b44d..6160a3fdc3022ad92d8b6c9863171dc951dd4e5b 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/containers/AuditApp.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/containers/AuditApp.jsx @@ -1,13 +1,10 @@ +/* eslint-disable react/prop-types */ import React from "react"; import SidebarLayout from "../components/SidebarLayoutFixedWidth"; import AuditSidebar from "../components/AuditSidebar"; -type Props = { - children: React.Element, -}; - -const AuditApp = ({ children }: Props) => ( +const AuditApp = ({ children }) => ( <SidebarLayout sidebar={<AuditSidebar />}> <div>{children}</div> </SidebarLayout> diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/containers/AuditDashboard.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/containers/AuditDashboard.jsx index 4beaba4e4373b8e83d8f9c235e49593cea45081f..a52d520a069db0e0d27354e16b34959cc939c8ae 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/containers/AuditDashboard.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/containers/AuditDashboard.jsx @@ -1,3 +1,4 @@ +/* eslint-disable react/prop-types */ import React from "react"; import { connect } from "react-redux"; @@ -11,15 +12,9 @@ const DashboardWithData = DashboardData(Dashboard); import { AuditMode } from "../lib/mode"; -import type { AuditCard } from "../types"; - import { harmony } from "metabase/lib/colors"; -type Props = { - cards: AuditCard[], -}; - -const AuditDashboard = ({ cards, ...props }: Props) => ( +const AuditDashboard = ({ cards, ...props }) => ( <DashboardWithData style={{ backgroundColor: "transparent", padding: 0 }} // HACK: to get inline dashboards working quickly diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/dashboard_detail.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/dashboard_detail.js index f371582cc196798fb5dd5b9346b5610b899ccfdd..882e18a6969e87b1a518cb6dd34402aa1aaf1258 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/dashboard_detail.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/dashboard_detail.js @@ -1,4 +1,4 @@ -export const viewsByTime = (dashboardId: number) => ({ +export const viewsByTime = dashboardId => ({ card: { name: "Views per day", display: "line", @@ -10,7 +10,7 @@ export const viewsByTime = (dashboardId: number) => ({ }, }); -export const revisionHistory = (dashboardId: number) => ({ +export const revisionHistory = dashboardId => ({ card: { name: "Revision history", display: "table", @@ -31,7 +31,7 @@ export const revisionHistory = (dashboardId: number) => ({ }, }); -export const cards = (dashboardId: number) => ({ +export const cards = dashboardId => ({ card: { name: "Cards", display: "table", @@ -43,7 +43,7 @@ export const cards = (dashboardId: number) => ({ }, }); -export const auditLog = (dashboardId: number) => ({ +export const auditLog = dashboardId => ({ card: { name: "Audit log", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/dashboards.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/dashboards.js index 2596f383f9a90d84074882886cc3090060c1205b..fb4bbc5ff82ac86be9fe6ce453a0333358f20ffb 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/dashboards.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/dashboards.js @@ -40,7 +40,7 @@ export const mostCommonQuestions = () => ({ }, }); -export const table = (searchString?: string) => ({ +export const table = searchString => ({ card: { name: "Dashboards", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/database_detail.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/database_detail.js index 438987f6365efdb5706c5f408d6294f207fb46b2..79be7dec6e516d64baf3bf244d1428beb0305ec2 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/database_detail.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/database_detail.js @@ -1,4 +1,4 @@ -export const auditLog = (databaseId: number) => ({ +export const auditLog = databaseId => ({ card: { name: "Audit log", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/databases.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/databases.js index 98cebbc4537c6900c8f98056b39271b7fb22a78e..86f336f26e3e4ae7995add13ac9b427b69333c0c 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/databases.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/databases.js @@ -54,7 +54,7 @@ export const queryExecutionsByTime = () => ({ }, }); -export const table = (searchString?: string) => ({ +export const table = searchString => ({ card: { name: "Databases", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/query_detail.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/query_detail.js index 23b23a3b3c6a011e15cc4be11fcd0dae44ed6003..3a4f85d4a26b4adda5732e9aa3e23b24200b6683 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/query_detail.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/query_detail.js @@ -1,4 +1,4 @@ -export const details = (queryHash: string) => ({ +export const details = queryHash => ({ card: { name: "Query details", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/question_detail.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/question_detail.js index 59b76e5f5f3b586575d2474fbbe3f9b375971323..e5cddbc5e88e5ae1f82ff19ad72c5c5b18f1239d 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/question_detail.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/question_detail.js @@ -40,7 +40,7 @@ export const averageExecutionTime = questionId => ({ }, }); -export const revisionHistory = (questionId: number) => ({ +export const revisionHistory = questionId => ({ card: { name: "Revision history", display: "table", @@ -61,7 +61,7 @@ export const revisionHistory = (questionId: number) => ({ }, }); -export const auditLog = (questionId: number) => ({ +export const auditLog = questionId => ({ card: { name: "Audit log", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/schemas.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/schemas.js index 57c800c87f64a6f1f155c29a82bed9baf14c85c0..5886a9a6e7c4a5a804e9088e18b74ebc405ec60f 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/schemas.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/schemas.js @@ -22,7 +22,7 @@ export const slowestSchemas = () => ({ }, }); -export const table = (searchString?: string) => ({ +export const table = searchString => ({ card: { name: "Schemas", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/table_detail.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/table_detail.js index 0f6b6e1b39e51882111809fc74cdbc3ff15a761f..1b58aff402f611adf5ca5e00950cb059edc54e4c 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/table_detail.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/table_detail.js @@ -1,4 +1,4 @@ -export const auditLog = (tableId: number) => ({ +export const auditLog = tableId => ({ card: { name: "Audit log", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/tables.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/tables.js index 14cdb8b5568a4fa1ac3e9878fbf89c2d9c531805..ded038f161bb1555e92a68e637eb11a046299baf 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/tables.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/tables.js @@ -30,7 +30,7 @@ export const leastQueried = () => ({ }, }); -export const table = (searchString?: string) => ({ +export const table = searchString => ({ card: { name: "Tables", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/user_detail.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/user_detail.js index b909cc88af447584e5dc02216c170f5aeaf19adf..1344634712ed4f0f1cae2ca24603c0597d562194 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/user_detail.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/user_detail.js @@ -1,4 +1,4 @@ -export const table = (userId: number) => ({ +export const table = userId => ({ card: { name: "Most-viewed Dashboards", display: "table", @@ -10,7 +10,7 @@ export const table = (userId: number) => ({ }, }); -export const mostViewedDashboards = (userId: number) => ({ +export const mostViewedDashboards = userId => ({ card: { name: "Most-viewed Dashboards", display: "row", @@ -27,7 +27,7 @@ export const mostViewedDashboards = (userId: number) => ({ }, }); -export const mostViewedQuestions = (userId: number) => ({ +export const mostViewedQuestions = userId => ({ card: { name: "Most-viewed Queries", display: "row", @@ -44,7 +44,7 @@ export const mostViewedQuestions = (userId: number) => ({ }, }); -export const objectViewsByTime = (userId: number) => ({ +export const objectViewsByTime = userId => ({ card: { name: "Query views", display: "line", @@ -69,7 +69,7 @@ export const objectViewsByTime = (userId: number) => ({ ], }); -export const queryViews = (userId: number) => ({ +export const queryViews = userId => ({ card: { name: "Query views", display: "table", @@ -91,7 +91,7 @@ export const queryViews = (userId: number) => ({ }, }); -export const dashboardViews = (userId: number) => ({ +export const dashboardViews = userId => ({ card: { name: "Dashboard views", display: "table", @@ -110,7 +110,7 @@ export const dashboardViews = (userId: number) => ({ }, }); -export const createdDashboards = (userId: number) => ({ +export const createdDashboards = userId => ({ card: { name: "Created dashboards", display: "table", @@ -122,7 +122,7 @@ export const createdDashboards = (userId: number) => ({ }, }); -export const createdQuestions = (userId: number) => ({ +export const createdQuestions = userId => ({ card: { name: "Created questions", display: "table", @@ -134,7 +134,7 @@ export const createdQuestions = (userId: number) => ({ }, }); -export const downloads = (userId: number) => ({ +export const downloads = userId => ({ card: { name: "Downloads", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/users.js b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/users.js index 2e02148f3b760a076894c91ac1987afaa97c484a..f7c52cc470a9e46eafaa0ebfdf32360eb7e30548 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/users.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/lib/cards/users.js @@ -88,7 +88,7 @@ export const queryExecutionTimePerUser = () => ({ }, }); -export const table = (searchString?: string) => ({ +export const table = searchString => ({ card: { name: "Users", display: "table", diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDashboards.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDashboards.jsx index 7a7e3bb447735c6576dcebd9c0e38caa4885ffb7..acf8ec368903e2d821db6ad8e043e05c9b853593 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDashboards.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDashboards.jsx @@ -1,3 +1,4 @@ +/* eslint-disable react/prop-types */ import React from "react"; import AuditContent from "../components/AuditContent"; @@ -6,11 +7,7 @@ import AuditTableWithSearch from "../containers/AuditTableWithSearch"; import * as DashboardCards from "../lib/cards/dashboards"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditDashboards = (props: Props) => ( +const AuditDashboards = props => ( <AuditContent {...props} title="Dashboards" tabs={AuditDashboards.tabs} /> ); diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDatabaseDetail.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDatabaseDetail.jsx index 565d36a07b8ecdfd9c05499e92c4d4bc030b5b3b..1d2cb52ae7f5d6e85d39a21f2a402d4169e75417 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDatabaseDetail.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDatabaseDetail.jsx @@ -8,11 +8,7 @@ import EntityName from "metabase/entities/containers/EntityName"; import * as DatabaseDetailCards from "../lib/cards/database_detail"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditDatabaseDetail = ({ params, ...props }: Props) => { +const AuditDatabaseDetail = ({ params, ...props }) => { const databaseId = parseInt(params.databaseId); return ( <AuditContent diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDatabases.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDatabases.jsx index 388a3b9dc296a4b89736a4f66dd5a8a9403d188f..a4169caf9a65fb32a47efa007ae54c4647325aaf 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDatabases.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDatabases.jsx @@ -1,3 +1,4 @@ +/* eslint-disable react/prop-types */ import React from "react"; import AuditContent from "../components/AuditContent"; @@ -6,11 +7,7 @@ import AuditTableWithSearch from "../containers/AuditTableWithSearch"; import * as DatabasesCards from "../lib/cards/databases"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditDatabases = (props: Props) => ( +const AuditDatabases = props => ( <AuditContent {...props} title="Databases" tabs={AuditDatabases.tabs} /> ); diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDownloads.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDownloads.jsx index e46d4f6c1b5b98dd2744b108edd2d2010a183c8c..f07ecc9edc72a7febaf5435a998d825e2f59d58a 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDownloads.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditDownloads.jsx @@ -1,3 +1,4 @@ +/* eslint-disable react/prop-types */ import React from "react"; import AuditContent from "../components/AuditContent"; @@ -6,11 +7,7 @@ import AuditTable from "../containers/AuditTable"; import * as DownloadsCards from "../lib/cards/downloads"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditDownloads = (props: Props) => ( +const AuditDownloads = props => ( <AuditContent {...props} title="Downloads" tabs={AuditDownloads.tabs} /> ); diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditOverview.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditOverview.jsx index 1c105c50642e607f429abbfbf8c31503ae3fd2fa..869233adc52c9f1e9a32fd723676431f6e0014de 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditOverview.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditOverview.jsx @@ -1,3 +1,4 @@ +/* eslint-disable react/prop-types */ import React from "react"; import AuditContent from "../components/AuditContent"; @@ -5,11 +6,7 @@ import AuditDashboard from "../containers/AuditDashboard"; import * as UsersCards from "../lib/cards/users"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditOverview = (props: Props) => ( +const AuditOverview = props => ( <AuditContent {...props} title="Overview"> <AuditDashboard cards={[ diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditQueryDetail.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditQueryDetail.jsx index 7652cdc8be5093ef329a759ceccc7682af3d4cba..65af3b94dcd731e8b276a218974de428d3371557 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditQueryDetail.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditQueryDetail.jsx @@ -14,11 +14,7 @@ import * as QueryDetailCards from "../lib/cards/query_detail"; import { serializeCardForUrl } from "metabase/lib/card"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditQueryDetail = ({ params: { queryHash } }: Props) => ( +const AuditQueryDetail = ({ params: { queryHash } }) => ( <AuditCustomView card={QueryDetailCards.details(queryHash)}> {({ result }) => { if (!result) { diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditQuestions.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditQuestions.jsx index 08b0a25a3beb3d151c025d333a90896a296c8df8..2e10e0a7ed23d055cdcb59edb5ec1681586e2240 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditQuestions.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditQuestions.jsx @@ -1,3 +1,4 @@ +/* eslint-disable react/prop-types */ import React from "react"; import AuditContent from "../components/AuditContent"; @@ -6,11 +7,7 @@ import { QuestionsAuditTable } from "../containers/QuestionsAuditTable"; import * as QueriesCards from "../lib/cards/queries"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditQuestions = (props: Props) => ( +const AuditQuestions = props => ( <AuditContent {...props} title="Questions" tabs={AuditQuestions.tabs} /> ); diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditSchemas.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditSchemas.jsx index 79b946971f0dea654a41f1323bb649b6f245874f..23b7ea5e05e71b37925a38d6741496e81c1a7be3 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditSchemas.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditSchemas.jsx @@ -1,3 +1,4 @@ +/* eslint-disable react/prop-types */ import React from "react"; import AuditContent from "../components/AuditContent"; @@ -6,11 +7,7 @@ import AuditTableWithSearch from "../containers/AuditTableWithSearch"; import * as SchemasCards from "../lib/cards/schemas"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditSchemas = (props: Props) => ( +const AuditSchemas = props => ( <AuditContent {...props} title="Schemas" tabs={AuditSchemas.tabs} /> ); diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditTableDetail.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditTableDetail.jsx index 1f20ee2c6d652d59c2329c904660e6c7a1c47db7..88cd1d9b15d51ebbbab8053fded5d9238756b193 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditTableDetail.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditTableDetail.jsx @@ -8,11 +8,7 @@ import EntityName from "metabase/entities/containers/EntityName"; import * as TableDetailCards from "../lib/cards/table_detail"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditTableDetail = ({ params, ...props }: Props) => { +const AuditTableDetail = ({ params, ...props }) => { const tableId = parseInt(params.tableId); return ( <AuditContent diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditTables.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditTables.jsx index e2eafc1e32f1501bb887816b46ab9251e5c7ec94..1c82e806d58f2e809ae2c9bc171adfe6c9ec296d 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditTables.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditTables.jsx @@ -1,3 +1,4 @@ +/* eslint-disable react/prop-types */ import React from "react"; import AuditContent from "../components/AuditContent"; @@ -6,11 +7,7 @@ import AuditTableWithSearch from "../containers/AuditTableWithSearch"; import * as TablesCards from "../lib/cards/tables"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditTables = (props: Props) => ( +const AuditTables = props => ( <AuditContent {...props} title="Tables" tabs={AuditTables.tabs} /> ); diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditUserDetail.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditUserDetail.jsx index 9fada8dd53a786016de6323035d591964e113486..01653cecd82c8a9887719bdf46f8632060bc03a4 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditUserDetail.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditUserDetail.jsx @@ -9,11 +9,7 @@ import EntityName from "metabase/entities/containers/EntityName"; import * as UserDetailCards from "../lib/cards/user_detail"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditUserDetail = ({ params, ...props }: Props) => { +const AuditUserDetail = ({ params, ...props }) => { const userId = parseInt(params.userId); return ( <AuditContent diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditUsers.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditUsers.jsx index d728da1dd14b446709f88fdec949d9b120274c2f..5ff36814007a0a987c6b45a6488d1b3acaeed730 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditUsers.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/pages/AuditUsers.jsx @@ -1,3 +1,4 @@ +/* eslint-disable react/prop-types */ import React from "react"; import AuditContent from "../components/AuditContent"; @@ -7,11 +8,7 @@ import AuditTableWithSearch from "../containers/AuditTableWithSearch"; import * as UsersCards from "../lib/cards/users"; -type Props = { - params: { [key: string]: string }, -}; - -const AuditUsers = (props: Props) => ( +const AuditUsers = props => ( <AuditContent {...props} title="Team members" tabs={AuditUsers.tabs} /> ); diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/routes.jsx b/enterprise/frontend/src/metabase-enterprise/audit_app/routes.jsx index 72444a17dad06a6feb0f0e59c9a56770e37a418f..1e38972da32a16c49d2e7d882d96e8169ab2a4a9 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/routes.jsx +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/routes.jsx @@ -27,17 +27,7 @@ import AuditUserDetail from "./pages/AuditUserDetail"; import AuditDownloads from "./pages/AuditDownloads"; import AuditSubscriptions from "./pages/AuditSubscriptions"; -type Page = { - tabs?: Tab[], -}; - -type Tab = { - path: string, - title: string, - component?: any, -}; - -function getPageRoutes(path, page: Page) { +function getPageRoutes(path, page) { const subRoutes = []; // add a redirect for the default tab const defaultTab = getDefaultTab(page); @@ -73,7 +63,7 @@ function getPageRoutes(path, page: Page) { ); } -function getDefaultTab(page: Page): ?Tab { +function getDefaultTab(page) { // use the tab with "default = true" or the first return ( _.findWhere(page.tabs, { default: true }) || @@ -82,7 +72,7 @@ function getDefaultTab(page: Page): ?Tab { ); } -const getRoutes = (store: any) => ( +const getRoutes = store => ( <Route key="audit" path="audit" title={t`Audit`} component={AuditApp}> {/* <IndexRedirect to="overview" /> */} <IndexRedirect to="members" /> diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/types.js b/enterprise/frontend/src/metabase-enterprise/audit_app/types.js index 65b4fc7cab69d5735b3d4d7b3c46447485ae4c92..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 100644 --- a/enterprise/frontend/src/metabase-enterprise/audit_app/types.js +++ b/enterprise/frontend/src/metabase-enterprise/audit_app/types.js @@ -1,15 +0,0 @@ -import type { Card } from "metabase-types/types/Card"; - -export type AuditDashCard = { - card: Card, - series?: Card[], -}; - -export type AuditCardPosition = { - x: number, - y: number, - w: number, - h: number, -}; - -export type AuditCard = [AuditCardPosition, AuditDashCard]; diff --git a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/GTAPModal.jsx b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/GTAPModal.jsx index 7803d8c376bdc616517ce7cc0a8bd0f4abd3d3be..9158a332008bb03b7f6c428daa2528d91949f622 100644 --- a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/GTAPModal.jsx +++ b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/GTAPModal.jsx @@ -35,29 +35,10 @@ const mapDispatchToProps = { updateTableSandboxingPermission, }; -type GTAP = { - table_id: ?number, - group_id: ?number, - card_id: ?number, - attribute_remappings: { [attribute: string]: any }, -}; - -type Props = { - params: { [name: string]: string }, - push: (url: string) => void, -}; -type State = { - gtap: ?GTAP, - attributesOptions: ?(string[]), - simple: boolean, - error: ?string, -}; - @withRouter @connect(mapStateToProps, mapDispatchToProps) export default class GTAPModal extends React.Component { - props: Props; - state: State = { + state = { gtap: null, attributesOptions: null, simple: true, @@ -328,7 +309,7 @@ const SummaryRow = ({ icon, content }) => ( </div> ); -const GTAPSummary = ({ gtap }: { gtap: GTAP }) => { +const GTAPSummary = ({ gtap }) => { return ( <div> <div className="px1 pb2 text-uppercase text-small text-grey-4"> @@ -407,7 +388,7 @@ const TableName = ({ tableId }) => ( </EntityObjectLoader> ); -const TargetName = ({ gtap, target }: { gtap: GTAP, target: any }) => { +const TargetName = ({ gtap, target }) => { if (Array.isArray(target)) { if ( (target[0] === "variable" || target[0] === "dimension") && diff --git a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/LoginAttributesWidget.jsx b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/LoginAttributesWidget.jsx index 214c929e5e63978b63bbaf57d5e172985068e2cc..f6c9638db23c39b6c1ee0e5917d5b67e9c4ea75c 100644 --- a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/LoginAttributesWidget.jsx +++ b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/LoginAttributesWidget.jsx @@ -1,21 +1,9 @@ +/* eslint-disable react/prop-types */ import React from "react"; import MappingEditor from "./MappingEditor"; -type LoginAttributes = { - [key: string]: string, -}; - -type FormField<T> = { - value: T, - onChange: (value: T) => void, -}; - -type Props = { - field: FormField<?LoginAttributes>, -}; - -const LoginAttributesWidget = ({ field }: Props) => ( +const LoginAttributesWidget = ({ field }) => ( <MappingEditor value={field.value || {}} onChange={field.onChange} diff --git a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/MappingEditor.jsx b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/MappingEditor.jsx index 418a9b4c09ba5cb7a9db64a96ff220c91a87f546..bddf29c841355e893689f310e834a1e9fa8245fa 100644 --- a/enterprise/frontend/src/metabase-enterprise/sandboxes/components/MappingEditor.jsx +++ b/enterprise/frontend/src/metabase-enterprise/sandboxes/components/MappingEditor.jsx @@ -5,32 +5,6 @@ import Button from "metabase/components/Button"; import _ from "underscore"; -type Mapping = { - [key: string]: any, -}; - -type Style = { - [key: string]: any, -}; - -type Props = { - value: Mapping, - onChange: (mapping: Mapping) => void, - className?: string, - style?: Style, - keyPlaceholder?: string, - valuePlaceholder?: string, - keyHeader?: React.Element<any>, - valueHeader?: React.Element<any>, - divider?: React.Element<any>, - canAdd?: boolean, - canDelete?: boolean, - addText?: string, - swapKeyAndValue?: boolean, - renderKeyInput?: any, // FIXME - renderValueInput?: any, // FIXME -}; - const DefaultRenderInput = ({ value, onChange, placeholder }) => ( <input className="input" @@ -56,7 +30,7 @@ const MappingEditor = ({ canDelete = true, addText = "Add", swapKeyAndValue, -}: Props) => { +}) => { const mapping = value; const entries = Object.entries(mapping); return ( diff --git a/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/QuestionParameterTargetWidget.jsx b/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/QuestionParameterTargetWidget.jsx index 43f80867fafd5b9109c146e71e451e7b107d45e7..0a959ed279a38c46b0eab7ef9490a556eb63c537 100644 --- a/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/QuestionParameterTargetWidget.jsx +++ b/enterprise/frontend/src/metabase-enterprise/sandboxes/containers/QuestionParameterTargetWidget.jsx @@ -6,20 +6,8 @@ import { QuestionLoaderHOC } from "metabase/containers/QuestionLoader"; import { getParameterMappingOptions } from "metabase/parameters/utils/mapping-options"; -import type { ParameterTarget } from "metabase-types/types/Parameter"; - -type Props = { - questionObject?: any, // FIXME: minimal card - questionId?: number, - questionHash?: string, - target: ?ParameterTarget, - onChange: (target: ?ParameterTarget) => void, -}; - @QuestionLoaderHOC export default class QuestionParameterTargetWidget extends React.Component { - props: Props; - render() { const { question, ...props } = this.props; const mappingOptions = question diff --git a/enterprise/frontend/src/metabase-enterprise/tools/routes.jsx b/enterprise/frontend/src/metabase-enterprise/tools/routes.jsx index 18533bb63bd6af05b1c1efdec202b1e32d8896f8..73bb293b1737f347e567f1c5d60d9216d47128fe 100644 --- a/enterprise/frontend/src/metabase-enterprise/tools/routes.jsx +++ b/enterprise/frontend/src/metabase-enterprise/tools/routes.jsx @@ -7,7 +7,7 @@ import ToolsApp from "./containers/ToolsApp"; import ErrorOverview from "./containers/ErrorOverview"; import ErrorDetail from "./containers/ErrorDetail"; -const getRoutes = (store: any) => ( +const getRoutes = store => ( <Route path="tools" title={t`Tools`} component={ToolsApp}> <IndexRedirect to="errors" /> <Route