diff --git a/frontend/src/admin/databases/databases.controllers.js b/frontend/src/admin/databases/databases.controllers.js index 5a35125996139a060f0f01d1ca19bbbf6b8abfa7..b92706071081ef2bbd8b2604b6bf2c560bf13306 100644 --- a/frontend/src/admin/databases/databases.controllers.js +++ b/frontend/src/admin/databases/databases.controllers.js @@ -1,8 +1,9 @@ +import _ from "underscore"; +import MetabaseSettings from "metabase/lib/settings"; import DatabaseList from "./components/DatabaseList.jsx"; import DatabaseEdit from "./components/DatabaseEdit.jsx"; -import _ from "underscore"; var DatabasesControllers = angular.module('metabaseadmin.databases.controllers', ['metabase.metabase.services']); @@ -49,13 +50,7 @@ DatabasesControllers.controller('DatabaseList', ['$scope', '$routeParams', 'Meta } }; - // load engine info from form_input endpoint. We need this to convert DB engine keys (e.g. 'postgres') to display names (e.g. 'PostgreSQL') - Metabase.db_form_input(function(formInput){ - $scope.engines = formInput.engines; - console.log('ENGINES: ', $scope.engines); - }, function(error) { - console.log('Error loading database form input: ', error); - }); + $scope.engines = MetabaseSettings.get('engines'); // fetch DBs from the backend Metabase.db_list(function(databases) { @@ -197,14 +192,11 @@ DatabasesControllers.controller('DatabaseEdit', ['$scope', '$routeParams', '$loc $scope.details = {}; } - // Ok, now load the engines from the form_input API endpoint - Metabase.db_form_input(function(formInput){ - $scope.engines = formInput.engines; - - if ($routeParams.databaseId) loadExistingDB(); - else prepareEmptyDB(); - }, function(error){ - console.log('Error loading database form input: ', error); - }); + $scope.engines = MetabaseSettings.get('engines'); + if ($routeParams.databaseId) { + loadExistingDB(); + } else { + prepareEmptyDB(); + } } ]); diff --git a/frontend/src/metabase/metabase.services.js b/frontend/src/metabase/metabase.services.js index 601604dd1ee5d17715e851577d011f7d27105bbd..a63c4b147078e483b3c734ca61cce7add3c8bd8e 100644 --- a/frontend/src/metabase/metabase.services.js +++ b/frontend/src/metabase/metabase.services.js @@ -7,10 +7,6 @@ var MetabaseServices = angular.module('metabase.metabase.services', [ MetabaseServices.factory('Metabase', ['$resource', '$cookies', 'MetabaseCore', function($resource, $cookies, MetabaseCore) { return $resource('/api/meta', {}, { - db_form_input: { - url: '/api/database/form_input', - method: 'GET' - }, db_list: { url: '/api/database/?org=:orgId', method: 'GET',