diff --git a/frontend/src/metabase/dashboard/containers/ParameterWidget.jsx b/frontend/src/metabase/dashboard/containers/ParameterWidget.jsx index cb81c3845169edfde21e6791528d0063d352d951..9f7ab1ba4a955fc5f7edd74b0fcb3219083b4338 100644 --- a/frontend/src/metabase/dashboard/containers/ParameterWidget.jsx +++ b/frontend/src/metabase/dashboard/containers/ParameterWidget.jsx @@ -36,11 +36,13 @@ export default class ParameterWidget extends Component { } static propTypes = { - parameter: PropTypes.object + parameter: PropTypes.object, + commitImmediately: PropTypes.object }; static defaultProps = { parameter: null, + commitImmediately: false } getValues() { @@ -56,7 +58,7 @@ export default class ParameterWidget extends Component { } renderPopover(value, setValue, placeholder, isFullscreen) { - const {parameter, editingParameter} = this.props; + const {parameter, editingParameter, commitImmediately} = this.props; const isEditingParameter = !!(editingParameter && editingParameter.id === parameter.id); const values = this.getValues(); return ( @@ -70,6 +72,7 @@ export default class ParameterWidget extends Component { placeholder={placeholder} focusChanged={this.focusChanged} isFullscreen={isFullscreen} + commitImmediately={commitImmediately} /> ); } diff --git a/frontend/src/metabase/dashboard/containers/Parameters.jsx b/frontend/src/metabase/dashboard/containers/Parameters.jsx index 27922677a5f5ab5172ed0918ac7f465698bb0861..80a6b3963078581605584f5b654bb11ab84a74de 100644 --- a/frontend/src/metabase/dashboard/containers/Parameters.jsx +++ b/frontend/src/metabase/dashboard/containers/Parameters.jsx @@ -11,6 +11,7 @@ export default class Parameters extends Component { defaultProps = { syncQueryString: false, vertical: false, + commitImmediately: false } componentWillMount() { @@ -62,7 +63,8 @@ export default class Parameters extends Component { editingParameter, setEditingParameter, isEditing, isFullscreen, isNightMode, isQB, setParameterName, setParameterValue, setParameterDefaultValue, removeParameter, - vertical + vertical, + commitImmediately } = this.props; const parameters = this._parametersWithValues(); @@ -88,6 +90,8 @@ export default class Parameters extends Component { setValue={(value) => setParameterValue(parameter.id, value)} setDefaultValue={(value) => setParameterDefaultValue(parameter.id, value)} remove={() => removeParameter(parameter.id)} + + commitImmediately={commitImmediately} /> ) } </div> diff --git a/frontend/src/metabase/query_builder/components/NativeQueryEditor.jsx b/frontend/src/metabase/query_builder/components/NativeQueryEditor.jsx index 645519774829e6067f5ae4a151203d72d76bf3da..ecfa64d17dd72b8c416c139e6e67dc9b05799b9f 100644 --- a/frontend/src/metabase/query_builder/components/NativeQueryEditor.jsx +++ b/frontend/src/metabase/query_builder/components/NativeQueryEditor.jsx @@ -348,6 +348,7 @@ export default class NativeQueryEditor extends Component { setParameterValue={setParameterValue} syncQueryString isQB + commitImmediately /> <a className="Query-label no-decoration flex-align-right flex align-center px2" onClick={this.toggleEditor}> <span className="mx2">{toggleEditorText}</span>