From 6e2f3293414355224531b5220f1a13bbe8ebe68b Mon Sep 17 00:00:00 2001
From: Anton Kulyk <kuliks.anton@gmail.com>
Date: Tue, 20 Sep 2022 17:33:25 +0100
Subject: [PATCH] Open chill-mode when clicking bookmarked model (#25515)
* Open chill-mode when clicking bookmarked model
* Fix unit test
---
frontend/src/metabase/lib/urls/bookmarks.ts | 9 +--------
frontend/test/metabase/lib/urls.unit.spec.js | 2 +-
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/frontend/src/metabase/lib/urls/bookmarks.ts b/frontend/src/metabase/lib/urls/bookmarks.ts
index eb6c0bddc38..6aacebbb228 100644
--- a/frontend/src/metabase/lib/urls/bookmarks.ts
+++ b/frontend/src/metabase/lib/urls/bookmarks.ts
@@ -1,9 +1,6 @@
import slugg from "slugg";
-import {
- isDataAppBookmark,
- isModelBookmark,
-} from "metabase/entities/bookmarks";
+import { isDataAppBookmark } from "metabase/entities/bookmarks";
import { Bookmark, DataApp } from "metabase-types/api";
@@ -27,10 +24,6 @@ export function bookmark(bookmark: Bookmark) {
);
}
- if (isModelBookmark(bookmark)) {
- return `/model/${itemId}/detail`;
- }
-
const basePath = getBookmarkBasePath(bookmark);
const itemPath = appendSlug(itemId, slugg(bookmark.name));
return `/${basePath}/${itemPath}`;
diff --git a/frontend/test/metabase/lib/urls.unit.spec.js b/frontend/test/metabase/lib/urls.unit.spec.js
index fdf390fc2dd..7263e4aa9dc 100644
--- a/frontend/test/metabase/lib/urls.unit.spec.js
+++ b/frontend/test/metabase/lib/urls.unit.spec.js
@@ -290,7 +290,7 @@ describe("urls", () => {
name: "Product",
type: "card",
}),
- ).toBe("/model/1/detail");
+ ).toBe("/model/1-product");
});
it("returns dashboard bookmark path", () => {
--
GitLab