From 72d23d2b8e5a1f93b288e5a8738758c9b05d3766 Mon Sep 17 00:00:00 2001
From: Alexander Polyankin <alexander.polyankin@metabase.com>
Date: Fri, 19 Aug 2022 15:05:04 +0300
Subject: [PATCH] Set default engine in admin database forms to postgres
(#24826)
---
frontend/src/metabase/admin/databases/database.js | 4 ++--
frontend/src/metabase/lib/engine.js | 5 +++++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/frontend/src/metabase/admin/databases/database.js b/frontend/src/metabase/admin/databases/database.js
index 2241b8f962c..072c1e73c1a 100644
--- a/frontend/src/metabase/admin/databases/database.js
+++ b/frontend/src/metabase/admin/databases/database.js
@@ -7,7 +7,7 @@ import {
} from "metabase/lib/redux";
import { push } from "react-router-redux";
import * as MetabaseAnalytics from "metabase/lib/analytics";
-import MetabaseSettings from "metabase/lib/settings";
+import { getDefaultEngine } from "metabase/lib/engine";
import { MetabaseApi } from "metabase/services";
import Databases from "metabase/entities/databases";
@@ -121,7 +121,7 @@ export const initializeDatabase = function (databaseId) {
const newDatabase = {
name: "",
auto_run_queries: true,
- engine: Object.keys(MetabaseSettings.get("engines"))[0],
+ engine: getDefaultEngine(),
details: {},
created: false,
};
diff --git a/frontend/src/metabase/lib/engine.js b/frontend/src/metabase/lib/engine.js
index 4d88f7f636b..03ada35edd4 100644
--- a/frontend/src/metabase/lib/engine.js
+++ b/frontend/src/metabase/lib/engine.js
@@ -1,6 +1,11 @@
import Settings from "metabase/lib/settings";
import { formatSQL } from "metabase/lib/formatting";
+export function getDefaultEngine() {
+ const engines = Object.keys(Settings.get("engines"));
+ return engines.includes("postgres") ? "postgres" : engines[0];
+}
+
export function getEngineNativeType(engine) {
switch (engine) {
case "mongo":
--
GitLab