From 743ae09aca8c790e22f9efb4cc9f31a6954d541a Mon Sep 17 00:00:00 2001 From: Oleksandr Yakushev <alex@bytopia.org> Date: Fri, 23 Aug 2024 09:53:08 +0300 Subject: [PATCH] perf: [insights] Use direct conversions in ->millis-from-epoch to avoid clojure.java-time overhead (#47145) --- src/metabase/analyze/fingerprint/insights.clj | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/metabase/analyze/fingerprint/insights.clj b/src/metabase/analyze/fingerprint/insights.clj index 7a5dfa50055..9bd6812d83d 100644 --- a/src/metabase/analyze/fingerprint/insights.clj +++ b/src/metabase/analyze/fingerprint/insights.clj @@ -178,9 +178,9 @@ (defn- ->millis-from-epoch [t] (when t (condp instance? t - Instant (t/to-millis-from-epoch t) - OffsetDateTime (t/to-millis-from-epoch t) - ZonedDateTime (t/to-millis-from-epoch t) + Instant (.toEpochMilli ^Instant t) + OffsetDateTime (.toEpochMilli (.toInstant ^OffsetDateTime t)) + ZonedDateTime (.toEpochMilli (.toInstant ^ZonedDateTime t)) LocalDate (->millis-from-epoch (t/offset-date-time t (t/local-time 0) (t/zone-offset 0))) LocalDateTime (->millis-from-epoch (t/offset-date-time t (t/zone-offset 0))) LocalTime (->millis-from-epoch (t/offset-date-time (t/local-date "1970-01-01") t (t/zone-offset 0))) -- GitLab